Conversation
|
RitwikSrivastava
changed the title
RitwikSrivastava
changed the title
helms-charity
left a comment
helms-charity
left a comment
There was a problem hiding this comment.
There are a couple of changes inline you can try so the image isn't cut off, but also please display:none this container in widths less than 768px wide, like the live site does.
aemedge/blocks/carousel/carousel.css
Outdated
|
|
||
| .carousel.wide .carousel-slide .carousel-slide-image picture > img { | ||
| width: 100%; | ||
| height: 100%; |
There was a problem hiding this comment.
remove height since you have object-fit: cover.
aemedge/blocks/carousel/carousel.css
Outdated
| /* stylelint-disable-next-line no-descending-specificity */ | ||
| .carousel.wide .carousel-slide { | ||
| min-width: 100%; /* Full width slides */ | ||
| height: 400px; /* Adjust height as needed */ |
There was a problem hiding this comment.
Remove height: 400px;
instead, add
aspect-ratio: 15 / 4;
helms-charity
left a comment
helms-charity
left a comment
There was a problem hiding this comment.
Can you also make sure auto-scroll works for this page /latino-es/service/centroamerica like the original?
Autoscroll also added . |
|
Closing this. will raise a new PR in da-pilot repo as this needs some more work. |
2 participants
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #552
Test URLs: