Skip to content

Add tab carousel variant#560

Merged
RitwikSrivastava merged 4 commits intomainfrom
carouseltab
Mar 21, 2025
Merged

Add tab carousel variant#560
RitwikSrivastava merged 4 commits intomainfrom
carouseltab

Conversation

@RitwikSrivastava
Copy link
Copy Markdown
Collaborator

@RitwikSrivastava RitwikSrivastava commented Mar 17, 2025

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #555

Test URLs:

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync bot commented Mar 17, 2025

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync bot commented Mar 17, 2025

Page Scores Audits Google
📱 /drafts/import-02-24/programming/max PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
🖥️ /drafts/import-02-24/programming/max PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

Copy link
Copy Markdown
Collaborator

@helms-charity helms-charity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are problems with the carousel slides when in this tab formation. Here were the in-browser edits I made that made the slide images look more similar to the original, and not cut off in tablet/desktop view:

Removed the object-fit and height/widths from the image element
image

Removed the height/width from the picture element
image

Removed height/width from the li element:
image

Removed max-width from the block div, and replaced with width: 66% to match the live site:
image

Then remove the 600px height, since we want that to be proportionate to the 66% width:
image

Mobile carousel has some work needed as-is too, though after applying the other suggested edits above, the adjustments will be different.
image

@RitwikSrivastava
Copy link
Copy Markdown
Collaborator Author

@helms-charity made changes to make it look as close as possible to live site in all views.

Copy link
Copy Markdown
Collaborator

@helms-charity helms-charity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is close enough :-)

@RitwikSrivastava RitwikSrivastava merged commit 81590c6 into main Mar 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Import] only carousel inside tabs variant

2 participants