Ala disseminate tribal knowledge into readme on partitions and break times#54
Open
Alb0t wants to merge 4 commits intoaerospike:masterfrom
Conversation
|
In general everything that is said is good. There are two points that may need a small tweak. The following sentence may not be clear to someone just looking at ACT for the first time. "For example, if you try to run a 100x test against a drive that only supports 20x - the drive may only pass at 10x. " The following comment doesn't seem necessary. "and is not well understood by the ACT community currently." I think other than that it all looks good. |
Fix some wording, add a blurb about irqbalance.
Alb0t
force-pushed
the
ala-disseminate-tribal-knowledge-into-readme-on-partitions-and-break-times
branch
from
bfc653a to
fb89300
Compare
Author
|
This came up again w/ some vendor conversations. Updated based on feedback. Feelings @tiboratAS ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wording could use some work and I'm not sure if there is a better "rule of thumb" to give, but this is about what we do.