Fix shape check in modularity.py#134
Merged
aestrivex merged 1 commit intoaestrivex:masterfrom Sep 16, 2025
mibur1:patch-1
Merged
Fix shape check in modularity.py#134aestrivex merged 1 commit intoaestrivex:masterfrom mibur1:patch-1
aestrivex merged 1 commit intoaestrivex:masterfrom
mibur1:patch-1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces an identity comparison with a literal tuple with a value-based comparison
Using
is not ()triggers a SyntaxWarning in recent Python versions, sinceis/is notcheck object identity rather than equality. The intended behaviour is to check whether the shape tuple is non-empty, which is correctly expressed with!= ().