Adding optional animation for drawing the lines#66
Open
joaortk wants to merge 2 commits intoaeyrium:masterfrom
Open
Adding optional animation for drawing the lines#66joaortk wants to merge 2 commits intoaeyrium:masterfrom
joaortk wants to merge 2 commits intoaeyrium:masterfrom
Conversation
| ); | ||
|
|
||
| if(widget.animateAppear) { | ||
| var controller = AnimationController( |
Collaborator
There was a problem hiding this comment.
can you change to final instead of var here? controller won't be modified
Collaborator
|
Thanks for the contribution !! I added a small comment in your code |
Collaborator
|
One question I have, did you try with a big chart data? like weekly scale? Could you add a GIF about that case? |
Collaborator
|
Hi @joaortk do you have any news about the feedback I gave you ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simple addition, allowing the user to enable animation on the line drawing.
