Skip to content

Security Fix for Prototype Pollution - huntr.dev #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huntr-helper wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Security Fix for Prototype Pollution - huntr.dev #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d1d558c
prototype pollution fix
d3v53c Jan 15, 2021
f4fc0dd
added testcase
d3v53c Jan 15, 2021
409024b
Merge pull request #1 from d3v53c/huntr/proto-01
JamieSlome Jan 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions __tests__/index.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,14 @@
expect(data).toEqual({ name: 'afei' });
});

test('set can prevent prototype pollution', function () {
var data = {};
var operator = new NxObjectOperator(data);
operator.set('__proto__.polluted', 'Yes, its polluted.');
expect(data.polluted).toEqual(undefined);
expect({}.polluted).toEqual(undefined);
});

test('get should get the right value', function () {
var data = {};
var operator = new NxObjectOperator(data);
Expand Down
15 changes: 13 additions & 2 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,30 @@
var global = global || this || window || Function('return this')();
var nx = global.nx || require('@jswork/next');

var isPrototypePolluted = function(key) {
return ['__proto__', 'prototype', 'constructor'].includes(key);
}

var set = function(data, key, value) {
if (String(key).split(".").some(function(k) {
return isPrototypePolluted(k);
})) return false;
nx.set(data, key, value);
}

var NxObjectOperator = nx.declare('nx.ObjectOperator', {
methods: {
init: function (inData) {
this.data = inData;
},
set: function (inPath, inValue) {
nx.set(this.data, inPath, inValue);
set(this.data, inPath, inValue);
},
sets: function (inObject) {
nx.forIn(
inObject,
function (key, value) {
nx.set(this.data, key, value);
set(this.data, key, value);
},
this
);
Expand Down