Make emc.py compatible with Python3, fix KPOINTS for CASTEP#25
Open
ganphys wants to merge 2 commits intoafonari:masterfrom
Open
Make emc.py compatible with Python3, fix KPOINTS for CASTEP#25ganphys wants to merge 2 commits intoafonari:masterfrom
ganphys wants to merge 2 commits intoafonari:masterfrom
Conversation
Add `from __future__ import print_function` and edit the print functions to work in Python3
CASTEP assigns kpoints weights automatically, hence there is no need for them in the KPOINTS file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edited the print functions to work with Python3, added
from __future__ import print_functionat the start to keep the Python2 compatibility, created an if case for CASTEP's KPOINTS file and removed the 0.01 weights from it.