Validation of constant values fail if case differs#29
Open
jhamsle wants to merge 1 commit intoafrunt:masterfrom
Open
Validation of constant values fail if case differs#29jhamsle wants to merge 1 commit intoafrunt:masterfrom
jhamsle wants to merge 1 commit intoafrunt:masterfrom
Conversation
The Fed seems to be okay with lowercase values for items, such as files using IAT transaction type code 'mis' even though documentation lists 'MIS'. All documentation I've seen cites upper case only, but the documentation itself does not specify if upper case is required, and the Fed itself doesn't reject files using lowercase, so I must assume they're okay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Fed seems to be okay with lowercase values for items, such as files using IAT transaction type code 'mis' even though documentation lists 'MIS'. All documentation I've seen cites upper case only, but the documentation itself does not specify if upper case is required, and the Fed itself doesn't reject files using lowercase, so I must assume they're okay.
I'm open to other ways to fix this. I figured this would address the issue in any possible logic with any possible object, which potentially is overreaching. Perhaps I should've included this for classes using @values, too.