Implementing color change in the selected item from ListInput #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fgemig
changed the title
fgemig
changed the title
afucher
requested changes
Oct 14, 2020
| console.WriteLine(item.Message); | ||
| }); | ||
| Newline(); | ||
| console.ResetColor(); |
Owner
There was a problem hiding this comment.
I think that this console.ResetColor() should be inside the loop.
If we have 3 messages:
- Console.Color = Cyan
- Console.Color = (Not set)
- Console.Color = Red
The second message will print Cyan, and I was expecting it to be the default Console color.
Could you please add some test to cover that? If need any help let me know
| }); | ||
| Newline(); | ||
| console.ResetColor(); | ||
| bottomContent.ToList().ForEach(item => console.WriteLine(item.Message)); |
Owner
There was a problem hiding this comment.
Since the bottomContent is also of the type ConsoleMessage, we should check the Color the same way that you have done for the content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The proposed change makes it possible to change the color in the selected ListInput item.
Motivation
This change improves the way the user views the selected items in the list, avoiding choosing an incorrect item.
Example
Well, I hope that this implementation will be useful for the community. I am open to questions and accept feedbacks!