Skip to content

adds ability for consumer to override error message #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mii9000 wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

adds ability for consumer to override error message #25

mii9000 wants to merge 3 commits into from

Conversation

@mii9000
Copy link

@mii9000 mii9000 commented Oct 16, 2020

#24

  1. I did not see the advantage of GetErrorMessage being a method so changed it to a property
  2. With abstract class the setting of error message does not need to be repeated in current validators

@afucher Please let me know your thoughts on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mii9000