-
Notifications
You must be signed in to change notification settings - Fork 257
Add doc/
to the target in Makefile and make the cabal
command customizable
#2830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with the output of GenerateEverything
going (back) to doc/
, assuming everything else keeps working. But definitely @gallais and @MatthewDaggitt need to also look at this.
I believe GenerateEverything already puts Everything.agda in doc since #2184. This PR does not change its |
This seems a reasonable set of changes to me! |
@gallais For the change from |
AGDA_OPTIONS=-Werror | ||
AGDA_RTS_OPTIONS=+RTS -M4.0G -H3.5G -A128M -RTS | ||
AGDA=$(AGDA_EXEC) $(AGDA_OPTIONS) $(AGDA_RTS_OPTIONS) | ||
CABAL_EXEC ?= cabal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to call this CABAL
(because you are referring to it as such below).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops thanks for catching the bug. I'll fix them later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok then I flag this as "changes requested".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the CABAL env var
The commits include two changes:
doc/
prefix to theEverything.agda
targets in GNUmakefilecabal
a makefile variable, thus allowing the user to substitute a different command (or designate a specific binary).I believe (1) is a leftover of #2184. This change stops two consecutive
make listings
calls from re-generating the documentation.(2) allows the user to use custom commands, e.g. using stack:
However,
fix-whitespace
,check-whitespace
andtest
seem to be cabal-specific, so I only make the cabal path customizable.CI: shhyou#1