Skip to content

Conversation

@gallais
Copy link
Member

@gallais gallais commented Nov 25, 2025

  • Start by checking the required unix utils are installed
  •  Run through https://www.shellcheck.net/
  • Add documentation (including in release checklist)
  • Add curl-based command for users to run

Comment on lines +137 to +138
if ! grep -Eq "^standard-library$" "defaults-$AGDA_VERSION"; then
echo "standard-library" >> "defaults-$AGDA_VERSION"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we specify the version number?


# Double check that the command exists
if ! [ -x "$(command -v $AGDA_EXEC)" ]; then
throwError "'$AGDA_EXEC' is not a valid executable"
Copy link
Member Author

@gallais gallais Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we check if e.g. $HOME/.cabal/bin/$AGDA_EXEC exists and suggest that the user should be adding $HOME/.cabal/bin/ to their PATH?

Copy link
Member

@Taneb Taneb Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can get cabal's default install path from cabal with cabal path --installdir

@MatthewDaggitt
Copy link
Contributor

In theory this looks great.

How cross platform is this and what do we need to do to support a new release? It looks like we just update the lookup table?

@gallais
Copy link
Member Author

gallais commented Nov 26, 2025

It won't work on windows but I'm keeping it as simple as possible in the hope it'd work on
any unix style system. So far we only need simple things like /bin/sh, grep, echo, true,
read.

And, indeed, the only update would be to the lookup table.

# Downloading and extracting the standard library
STDLIB_TARBALL_NAME="/tmp/agda-stdlib-$STDLIB_VERSION.tar.gz"
STDLIB_TARBALL_URL="https://github.com/agda/agda-stdlib/archive/$STDLIB_TAG.tar.gz"
wget -O "$STDLIB_TARBALL_NAME" "$STDLIB_TARBALL_URL" -o logs/wget
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Catch errors and report them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants