feat(pool): squash merge + persist review to SQLite#40
Merged
robotlearning123 merged 1 commit intomainfrom Mar 5, 2026
Merged
Conversation
Squash merge: release(name, true, taskId) now squash-merges agent
commits into a single result commit on main. Full agent history
preserved at refs/tasks/{taskId}. Without taskId, falls back to
legacy ff/merge for backward compat. Uses temp branch + update-ref
pattern since worktrees can't checkout main directly.
Review persistence: task.review (ReviewResult) round-trips through
SQLite via new review TEXT column with JSON serialization.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
release(name, true, taskId)squash-merges agent commits into a single result commit on main (task({id}): {summary}). Full agent history preserved atrefs/tasks/{taskId}. WithouttaskId, falls back to legacy ff/merge for backward compat.task.review(ReviewResult) persisted to SQLite via newreview TEXTcolumn. Round-trips correctly through save/get/update.ReviewResultinterface andreview?: ReviewResulttoTask.Key design decisions
update-refpattern because git worktrees can't checkoutmaindirectly (it's already checked out by the parent repo)refs/tasks/{id}only created after successful merge (no orphaned refs on conflict)cleanupTmpBranch()helper to eliminate 4x copy-pasteKnown follow-up
ReviewResultinterface exists inagent-runner.ts(lacksapprovefield). Should unify withtypes.tsversion in a follow-up PR.Test plan
npx tsc --noEmit— cleannpm test— 290/290 pass (0 fail)refs/tasks/{id}preserves all agent commitsundefinedafter loadupdate()can set review field🤖 Generated with Claude Code