fix(gardener): align push-mode workflow with Claude Code auth#336
fix(gardener): align push-mode workflow with Claude Code auth#336bingran-you merged 1 commit intomainfrom
Conversation
|
🌱 gardener · 🔍
Context fitContext match
Tree nodes referenced
RecommendationWhy: Shifts CI auth from API-key-primary to Claude Code OAuth-primary; maintains API-key fallback. Warrants review against auth architecture decisions. Suggested path forward: See the tree nodes cited above for the decision this touches. Reviewed commit: 🌱 Posted by repo-gardener — an open-source context-aware review bot built on First-Tree. Reviews this repo against a user-maintained context tree. Not affiliated with this project's maintainers. |
yuezengwu
left a comment
There was a problem hiding this comment.
LGTM. Ran pnpm exec vitest run tests/gardener/gardener-install-workflow.test.ts (21/21 ✓) and pnpm typecheck (clean) locally.
The template now matches the live .github/workflows/first-tree-sync.yml that you verified end-to-end, and the auth precedence lines up with selectClassifier (src/products/gardener/engine/classifiers/select.ts:85): claude on PATH → CLAUDE_CODE_OAUTH_TOKEN, fall back to ANTHROPIC_API_KEY, fail-closed otherwise. Nice cleanup dropping the duplicate ANTHROPIC_API_KEY that was on both the job-env and step-env before.
A couple of tiny nits, non-blocking:
buildWorkflowYamlfork-skip comment still readsGitHub withholds secrets (TREE_REPO_TOKEN, CLAUDE_CODE_OAUTH_TOKEN)butCLAUDE_CODE_OAUTH_TOKENis now only bound at step-env, not job-env. Comment is still factually true (both are withheld on forks), just slightly less local.skills/gardener/SKILL.md§Environment — theANTHROPIC_API_KEYrow's fail-closed sentence now conflates the "neither wired" case with the one it used to describe alone. Reads fine, just flagging in case you want to tighten.
Approving. Feel free to land.
This reply was drafted by breeze, an autonomous agent running on behalf of the account owner.
Summary
install-workflowoutput with the Claude Code OAuth path already used by the live sync workflowCLAUDE_CODE_OAUTH_TOKENas the primary CI auth pathANTHROPIC_API_KEY/GARDENER_CLASSIFIER_MODELas optional fallback secrets in the generated workflowVerification
pnpm exec vitest run tests/gardener/gardener-install-workflow.test.tspnpm typecheckFirst-Tree Syncworkflow after refreshingTREE_REPO_TOKENand confirmed it now succeeds