add session/fork #277
Closed
add session/fork #277
+194
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks I'll take a l look in a bit, but yes, I am working on a fix for the TS side now 👍🏻 |
Contributor
Author
|
I'm sure you'll do it properly. For now I let Claude identify the problem and add custom processing to the generate script (agentclientprotocol/typescript-sdk@main...SteffenDE:acp-typescript-sdk:sd-fork-tmp#diff-5d8e53e65cc95851919124ab88f14ddb9958704a6c4bf4b9fcc0f2bfb67b919f). |
Member
|
@SteffenDE can you give me permission to push to this branch? |
Member
|
Otherwise I'll cherry-pick to a new one and do some small tweaks there |
Contributor
Author
|
I'm not sure how to best do that so I invited you as collaborator on the fork! |
Member
|
Thanks! |
Member
|
Moved it here because I gave up :D #311 |
SteffenDE
added a commit
to tidewave-ai/agent-client-protocol
that referenced
this pull request
Dec 9, 2025
Similar to agentclientprotocol#277 / agentclientprotocol#311. I did not regenerate the schema files for now.
benbrandt
pushed a commit
to tidewave-ai/agent-client-protocol
that referenced
this pull request
Dec 11, 2025
Similar to agentclientprotocol#277 / agentclientprotocol#311. I did not regenerate the schema files for now.
benbrandt
added a commit
that referenced
this pull request
Dec 11, 2025
benbrandt
added a commit
to zed-industries/claude-code-acp
that referenced
this pull request
Dec 12, 2025
Work in progress! Uses a fork for now. See agentclientprotocol/agent-client-protocol#277. --------- Co-authored-by: Ben Brandt <benjamin.j.brandt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to implement the session/fork RFD (#233).
Disclaimer: I gave the RFD to Claude and let it implement the code. I reviewed everything and it looks reasonable to me, but I'm not a Rust expert :)
I did encounter one issue when I tried to use the generated schema in the typescript-sdk, but I don't think it is related: in the schema.ts, the response types are missing, e.g.
NewSessionResponse. In fact, I get the same error trying to use 0.7.0, so it seems to be a general incompatibility.