Add Kubernetes event recording to AgentReconciler#82
Draft
Conversation
- Add Recorder events.EventRecorder field to AgentReconciler struct - Emit Normal/Created and Normal/Updated events from ensureDeployment and ensureService - Emit Normal/Updated event on successful reconciliation - Emit Warning/ReconcileFailed events on resolution/reconciliation failures - Wire recorder in cmd/main.go via mgr.GetEventRecorder - Update all 7 test files to supply fake recorder in BeforeEach Co-authored-by: fmallmann <30110193+fmallmann@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add event recording to AgentReconciler for improved observability
Add Kubernetes event recording to AgentReconciler
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentReconcilerhad no event emission despite RBAC markers already in place and the webhook layer already usingevents.EventRecorder. This adds observability into reconciliation activity viakubectl describe agent.Changes
AgentReconcilerstruct — addedRecorder events.EventRecorderfield (samek8s.io/client-go/tools/eventspackage as the webhook layer; no new dependencies)emitEventhelper — nil-guarded wrapper aroundRecorder.Eventfso the field is optionalNormal/Created— Deployment or Service newly createdNormal/Updated— Deployment or Service updated; successful reconciliationWarning/ReconcileFailed— subAgent/tool/AiGateway resolution failure, Deployment or Service reconciliation failurecmd/main.go— wired recorder viamgr.GetEventRecorder("agent-controller")BeforeEachblocks updated to supply&events.FakeRecorder{}Example events visible after this change
Original prompt
💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.