Replace powershell with pwsh in Taskfile#196
Open
AgentX-asaf wants to merge 3 commits intomainfrom
Open
Conversation
PowerShell 5.1 (powershell.exe) cannot parse UTF-8 files with special characters. All 14 references updated to pwsh (PowerShell 7). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![reagentx-workflow[bot]](https://avatars.githubusercontent.com/in/2400215?s=60&v=4){kind=small}
There was a problem hiding this comment.
ReAgent Diagnostics
| Field | Value |
|---|---|
| ReAgent Version | 5.11.9 |
| Project Context | CLAUDE.md loaded |
| Model | claude-opus-4-5-20251101 |
| Deep Context | Disabled |
| Review Time | 11.6s |
| Timestamp | 2026-03-21T16:56:19Z |
| Repository | agentmuxai/agentmux |
| PR | #196 |
LGTM
Partner Center expects "AgentMux" not "AgentMux Corp". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
ReAgent Diagnostics
| Field | Value |
|---|---|
| ReAgent Version | 5.11.9 |
| Project Context | CLAUDE.md loaded |
| Model | claude-opus-4-5-20251101 |
| Deep Context | Disabled |
| Review Time | 7.6s |
| Timestamp | 2026-03-21T16:57:01Z |
| Repository | agentmuxai/agentmux |
| PR | #196 |
LGTM
- Name: AgentMux.AgentMux (was AgentMuxAI.AgentMux) - Publisher: CN=C2BCB530-27CD-4DCF-87C5-2967CE009AAC - Remove placeholder warning from packaging script Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
ReAgent Diagnostics
| Field | Value |
|---|---|
| ReAgent Version | 5.11.9 |
| Project Context | CLAUDE.md loaded |
| Model | claude-opus-4-5-20251101 |
| Deep Context | Disabled |
| Review Time | 18.9s |
| Timestamp | 2026-03-21T16:59:21Z |
| Repository | agentmuxai/agentmux |
| PR | #196 |
I've reviewed all the changes. The PR:
- Replaces 14
powershellreferences withpwshin Taskfile.yml - straightforward find/replace - Includes a proper version bump (0.32.64 → 0.32.65) across all version files
- Updates MSIX identity/publisher to match Partner Center account (related commits in the PR)
- Removes the now-unnecessary placeholder warning in package-msix.ps1
The changes are valid:
pwshis the correct executable name for PowerShell 7, which handles UTF-8 better- Version bump is present and unique
- All 14 replacements are consistent
- The MSIX manifest and script updates are consistent with each other
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
powershellreferences withpwsh(PowerShell 7) in Taskfile.ymlpowershell.exe) cannot parse UTF-8 files with special characters (e.g., em dash—), which breakstask package:msixand potentially other tasksTest plan
task package:msixcompletes without UTF-8 parsing errorstask package:portablestill workstask build:backendcopy steps work on Windows🤖 Generated with Claude Code