fix(linux): apply GTK opacity + scope stale backend cleanup by data dir#232
Open
AgentU-asaf wants to merge 2 commits intomainfrom
Open
fix(linux): apply GTK opacity + scope stale backend cleanup by data dir#232AgentU-asaf wants to merge 2 commits intomainfrom
AgentU-asaf wants to merge 2 commits intomainfrom
Conversation
**Opacity not working on Linux** set_window_transparency received opacity=0.75 but never applied it on Linux — the transparent+no-blur path fell through returning Ok(()) with no side effects. Fix: call gtk::Window::set_opacity() so the compositor composites the window at the correct transparency level. **Stale backend cleanup killing wrong instances** cleanup_stale_backends killed any agentmuxsrv-rs process whose --instance version differed from the current version, regardless of which app identifier owned it. This caused launching a dev build (task dev) to SIGKILL a running production AppImage's backend, making it go Offline. Fix: also parse --wavedata from the process cmdline and only kill backends whose wavedata path is under our own data_dir. Dev instances (.app.dev/...) and production instances (.app.vX-Y-Z/...) now have fully isolated cleanup. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
ReAgent Diagnostics
| Field | Value |
|---|---|
| ReAgent Version | 5.12.4 |
| Project Context | CLAUDE.md loaded |
| Model | claude-opus-4-6 |
| Effort | high |
| Ref Repos | Disabled |
| Merge Analysis | Clean |
| Review Time | 77.3s |
| Timestamp | 2026-03-26T00:29:09Z |
| Repository | agentmuxai/agentmux |
| PR | #232 |
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Opacity not working on Linux:
set_window_transparencyreceivedopacity=0.75but the transparent+no-blur path on Linux fell through returningOk(())with no side effects. Fix: callgtk::Window::set_opacity()so the compositor composites the window at the correct transparency level.Stale backend cleanup killing wrong instances:
cleanup_stale_backendskilled anyagentmuxsrv-rsprocess whose--instanceversion differed from the current version, regardless of which app identifier owned it. This caused launching a dev build (task dev) to SIGKILL a running production AppImage's backend, making it go Offline. Fix: also parse--wavedatafrom the process cmdline and only kill backends whose wavedata path is under our owndata_dir. Dev instances (.app.dev/...) and production instances (.app.vX-Y-Z/...) now have fully isolated cleanup.Test plan
task dev— AppImage should NOT go Offlinetask dev, close it, reopen — stale backend from same instance is still cleaned up correctly🤖 Generated with Claude Code