fix: Win11 focus border black color + packaging script resilience#300
Open
AgentX-asaf wants to merge 1 commit intomainfrom
Open
fix: Win11 focus border black color + packaging script resilience#300AgentX-asaf wants to merge 1 commit intomainfrom
AgentX-asaf wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
ReAgent Diagnostics
| Field | Value |
|---|---|
| ReAgent Version | 5.12.5 |
| Trigger | PR opened |
| Project Context | CLAUDE.md loaded |
| Model | claude-opus-4-6 |
| Effort | high |
| Ref Repos | Disabled |
| Merge Analysis | 1 regression(s) detected |
| Review Time | 29.6s |
| Timestamp | 2026-04-05T08:08:55Z |
| Repository | agentmuxai/agentmux |
| PR | #300 |
Issues:
- package.json:9 - Version downgrade detected: main is at 0.33.45 but this PR sets 0.33.44. Rebase on latest main and bump to 0.33.46
- frontend/app/block/blockframe.tsx:710 - Hardcoded fallback color
#419FE0— if the accent color theme changes, this won't update. Consider reading the resolved HEX value from the theme at runtime instead of hardcoding
c250589 to
f177f05
Compare
There was a problem hiding this comment.
ReAgent Diagnostics
| Field | Value |
|---|---|
| ReAgent Version | 5.12.5 |
| Trigger | Re-review (new commits) |
| Project Context | CLAUDE.md loaded |
| Model | claude-opus-4-6 |
| Effort | high |
| Ref Repos | Disabled |
| Merge Analysis | 1 regression(s) detected |
| Review Time | 57.0s |
| Timestamp | 2026-04-05T15:26:46Z |
| Repository | agentmuxai/agentmux |
| PR | #300 |
Issues:
- package.json:9 - Version downgrade: main is at 0.33.45 but this PR sets 0.33.44 (which already exists in main history at commit bfa5c81). Rebase on latest main and bump to 0.33.46
- frontend/app/block/blockframe.tsx:561 - Hardcoded fallback
#419FE0(duplicated at line 750) won't track theme changes to--accent-colordefined in theme.scss:14. Read the computed HEX value from the DOM at runtime instead of hardcoding
The focused pane border rendered black on Windows 11 because the default accent color used an RGB variable from :root, which CEF's compositor fails to resolve on backdrop-filter elements. Agent colors (HEX inline styles) rendered correctly. Unifies both paths into a single --block-focus-color inline style that always uses HEX, matching the working agent color path. Also fixes the packaging script for MSYS2 bash stdout corruption (drop set -e, add resilient log/die helpers) and changes powershell to pwsh. v0.33.44 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
f177f05 to
330334f
Compare
There was a problem hiding this comment.
ReAgent Diagnostics
| Field | Value |
|---|---|
| ReAgent Version | 5.12.5 |
| Trigger | Re-review (new commits) |
| Project Context | CLAUDE.md loaded |
| Model | claude-opus-4-6 |
| Effort | high |
| Ref Repos | Disabled |
| Merge Analysis | 1 regression(s) detected |
| Review Time | 58.7s |
| Timestamp | 2026-04-05T15:33:32Z |
| Repository | agentmuxai/agentmux |
| PR | #300 |
Issues:
- package.json:9 - Version downgrade: main is at 0.33.45 but this PR sets 0.33.44 (0.33.44 already exists in main at commit bfa5c81). Rebase on latest main and bump to 0.33.46
- frontend/app/block/blockframe.tsx:561 - Hardcoded fallback
#419FE0(duplicated at line 750) will drift if--accent-colorin theme.scss:14 is changed. UsegetComputedStyle(document.documentElement).getPropertyValue('--accent-color')resolved to HEX viacolord(already a dependency) instead of hardcoding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:root, which CEF's compositor fails to resolve onbackdrop-filterelements. Agent colors (HEX inline styles) rendered correctly. Unified both paths into a single--block-focus-colorinline style that always uses HEX.scripts/package-cef-portable.shfailed silently due to MSYS2 bash stdout FD corruption combined withset -euo pipefail. Droppedset -e, added resilientlog()/die()helpers with explicit error checks.powershell→pwsh: Changed PowerShell 5.1 call to PowerShell 7 per project rules.Changes
frontend/app/block/blockframe.tsx--block-agent-color+has-agent-colorclass with unified--block-focus-colorinline stylefrontend/app/block/block.scssvar(--block-focus-color)scripts/package-cef-portable.shset -e, addedlog()/die()helpers, explicit error checks,powershell→pwshRoot cause
CEF on Windows 11 has a compositor bug where
:rootCSS custom properties containing RGB values render as black when applied to elements withbackdrop-filter. The.block-maskelement usesbackdrop-filter: blur(0.1px)to force correct GPU compositing order above xterm's scroll layer. Agent-loaded terminals worked because their border color was set as an inline HEX style, bypassing the:rootvariable path entirely.Test plan
task cef:package:portable— should complete without silent failures🤖 Generated with Claude Code