Skip to content

feat: agent header border lines instead of solid fill#319

Open
AgentX-asaf wants to merge 6 commits intomainfrom
agentx/agent-header-border-style
Open

feat: agent header border lines instead of solid fill#319
AgentX-asaf wants to merge 6 commits intomainfrom
agentx/agent-header-border-style

Conversation

@AgentX-asaf
Copy link
Copy Markdown
Contributor

Summary

  • Replace solid colored background on agent terminal pane headers with colored top/bottom borders on dark background
  • Header top border (2px) and bottom border use the agent's color, creating two horizontal colored lines framing the header
  • Pane outer border + header borders now share the same color for visual consistency
  • Also a diagnostic step for the Win11 focus border bug: header borders use inline HEX (same working path as agent pane borders)

Changes

  • blockframe.tsx: Modified headerStyle memo — border-top and border-bottom-color instead of background-color

Test plan

  • Agent terminal (AgentX): header shows red top/bottom borders, dark bg
  • Non-agent terminal: header unchanged
  • Multiple agents: each shows its own color
  • Header controls still visible and clickable
  • Pane outer border matches header border color
  • Win11: verify header borders render correctly

🤖 Generated with Claude Code

AgentY-asaf and others added 2 commits April 8, 2026 22:50
Replace solid colored background on agent terminal headers with colored
top and bottom borders on a dark background. The header border color
matches the pane's outer border for visual consistency.

Also serves as a diagnostic for the Win11 focus border bug — header
borders use the same inline HEX path that works for agent pane borders.

Co-Authored-By: AgentX <agentx@asaf.cc>
Copy link
Copy Markdown

@reagentx-workflow reagentx-workflow Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReAgent Diagnostics
Field Value
ReAgent Version 5.12.5
Trigger PR opened
Project Context CLAUDE.md loaded
Model claude-opus-4-6
Effort high
Ref Repos Disabled
Merge Analysis Clean
Review Time 73.4s
Timestamp 2026-04-09T05:52:19Z
Repository agentmuxai/agentmux
PR #319

Issues:

  • package.json:9 - Version 0.33.66 already exists on main (merged via PR #316). Rebase on main and bump to 0.33.67+

AgentY-asaf and others added 2 commits April 8, 2026 23:37
BlockMask now sets border-color as an inline HEX value for all focused
panes, bypassing the Win11 backdrop-filter compositor bug where
var(--accent-color) from :root fails on initial GPU composite.

Agent panes get their agent color, vanilla panes get #419FE0 (accent blue).
Tab/block overrides still take precedence.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown

@reagentx-workflow reagentx-workflow Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReAgent Diagnostics
Field Value
ReAgent Version 5.12.5
Trigger Re-review (new commits)
Project Context CLAUDE.md loaded
Model claude-opus-4-6
Effort high
Ref Repos Disabled
Merge Analysis Clean
Review Time 71.3s
Timestamp 2026-04-09T06:39:00Z
Repository agentmuxai/agentmux
PR #319

Main already has 0.33.67. The PR's package-lock.json is stuck at 0.33.66 while everything else says 0.33.67. Here's my review:

Issues:

  • package.json:9 - Version 0.33.67 already exists on main (commit 8fb3d94). Rebase on main and bump to 0.33.68+
  • package-lock.json:3 - Version mismatch: shows 0.33.66 while package.json and all Cargo.toml files show 0.33.67. Run bump verify to fix consistency

AgentY-asaf and others added 2 commits April 8, 2026 23:52
- BlockMask: use props.focusColor instead of destructured param to
  preserve SolidJS reactivity when agent color changes
- Header: add border-left/border-right for vertical colored lines
  on agent pane headers

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown

@reagentx-workflow reagentx-workflow Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ReAgent Diagnostics
Field Value
ReAgent Version 5.12.5
Trigger Re-review (new commits)
Project Context CLAUDE.md loaded
Model claude-opus-4-6
Effort high
Ref Repos Disabled
Merge Analysis Clean
Review Time 49.4s
Timestamp 2026-04-09T06:54:07Z
Repository agentmuxai/agentmux
PR #319

Issues:

  • package-lock.json:3 - Version mismatch: shows 0.33.67 while package.json and all Cargo.toml files show 0.33.68. Run bump verify to fix consistency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants