feat: agent header border lines instead of solid fill#319
Open
AgentX-asaf wants to merge 6 commits intomainfrom
Open
feat: agent header border lines instead of solid fill#319AgentX-asaf wants to merge 6 commits intomainfrom
AgentX-asaf wants to merge 6 commits intomainfrom
Conversation
Replace solid colored background on agent terminal headers with colored top and bottom borders on a dark background. The header border color matches the pane's outer border for visual consistency. Also serves as a diagnostic for the Win11 focus border bug — header borders use the same inline HEX path that works for agent pane borders. Co-Authored-By: AgentX <agentx@asaf.cc>
There was a problem hiding this comment.
ReAgent Diagnostics
| Field | Value |
|---|---|
| ReAgent Version | 5.12.5 |
| Trigger | PR opened |
| Project Context | CLAUDE.md loaded |
| Model | claude-opus-4-6 |
| Effort | high |
| Ref Repos | Disabled |
| Merge Analysis | Clean |
| Review Time | 73.4s |
| Timestamp | 2026-04-09T05:52:19Z |
| Repository | agentmuxai/agentmux |
| PR | #319 |
Issues:
- package.json:9 - Version 0.33.66 already exists on main (merged via PR #316). Rebase on main and bump to 0.33.67+
BlockMask now sets border-color as an inline HEX value for all focused panes, bypassing the Win11 backdrop-filter compositor bug where var(--accent-color) from :root fails on initial GPU composite. Agent panes get their agent color, vanilla panes get #419FE0 (accent blue). Tab/block overrides still take precedence. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
ReAgent Diagnostics
| Field | Value |
|---|---|
| ReAgent Version | 5.12.5 |
| Trigger | Re-review (new commits) |
| Project Context | CLAUDE.md loaded |
| Model | claude-opus-4-6 |
| Effort | high |
| Ref Repos | Disabled |
| Merge Analysis | Clean |
| Review Time | 71.3s |
| Timestamp | 2026-04-09T06:39:00Z |
| Repository | agentmuxai/agentmux |
| PR | #319 |
Main already has 0.33.67. The PR's package-lock.json is stuck at 0.33.66 while everything else says 0.33.67. Here's my review:
Issues:
- package.json:9 - Version 0.33.67 already exists on main (commit 8fb3d94). Rebase on main and bump to 0.33.68+
- package-lock.json:3 - Version mismatch: shows 0.33.66 while package.json and all Cargo.toml files show 0.33.67. Run
bump verifyto fix consistency
- BlockMask: use props.focusColor instead of destructured param to preserve SolidJS reactivity when agent color changes - Header: add border-left/border-right for vertical colored lines on agent pane headers Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
ReAgent Diagnostics
| Field | Value |
|---|---|
| ReAgent Version | 5.12.5 |
| Trigger | Re-review (new commits) |
| Project Context | CLAUDE.md loaded |
| Model | claude-opus-4-6 |
| Effort | high |
| Ref Repos | Disabled |
| Merge Analysis | Clean |
| Review Time | 49.4s |
| Timestamp | 2026-04-09T06:54:07Z |
| Repository | agentmuxai/agentmux |
| PR | #319 |
Issues:
- package-lock.json:3 - Version mismatch: shows 0.33.67 while package.json and all Cargo.toml files show 0.33.68. Run
bump verifyto fix consistency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
blockframe.tsx: ModifiedheaderStylememo —border-topandborder-bottom-colorinstead ofbackground-colorTest plan
🤖 Generated with Claude Code