Open
Conversation
Add classic red/yellow/green traffic-light window controls on the LEFT of the macOS title bar, matching native macOS HIG behaviour. Windows and Linux keep the existing Win11-style caption buttons on the right. Platform split via Vite's platformResolve plugin: - window-controls.darwin.tsx — traffic lights (close/minimize/zoom), left-side; WindowControlsRight returns null - window-controls.win32.tsx — Win11 SVG buttons (46 px wide, full-height hit area), right-side; WindowControlsLeft returns null - window-controls.linux.tsx — re-exports from win32 - window-controls.platform.tsx — barrel stub for TS type-checking window-header.tsx renders <WindowControlsLeft /> before <WindowDrag> so the circles sit flush at the top-left. system-status.tsx renders <WindowControlsRight /> instead of the former inlined WindowActionButtons. Win11 button styles and macOS traffic-light styles moved to their respective platform scss files. --default-indent set to 0 on darwin since the traffic lights provide the left visual anchor. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![reagentx-workflow[bot]](https://avatars.githubusercontent.com/in/2400215?s=60&v=4){kind=small}
There was a problem hiding this comment.
ReAgent Diagnostics
| Field | Value |
|---|---|
| ReAgent Version | 5.12.5 |
| Trigger | PR opened |
| Project Context | CLAUDE.md loaded |
| Model | claude-opus-4-6 |
| Effort | high |
| Ref Repos | Disabled |
| Merge Analysis | 3 regression(s) detected |
| Review Time | 43.4s |
| Timestamp | 2026-04-18T19:32:53Z |
| Repository | agentmuxai/agentmux |
| PR | #444 |
LGTM
…ndle - bundle:darwin: implement framework copy (was stub) — copies CEF framework to dist/Frameworks/ and GPU libs (libGLESv2, libEGL) to dist/cef/ - main.rs: set framework_dir_path in CEF Settings so FrameworkBundlePath() can locate icudtl.dat — required on macOS 26 outside an .app bundle - app.rs: add --use-mock-keychain to suppress Keychain access dialog on every launch (AgentMux stores no browser passwords) - app.rs: add on_window_activation_changed to restore keyboard focus when switching back from another app (typing was routing to previous app) - client.rs: split wrap_keyboard_handler! into per-platform blocks to fix NativeKeyEvent type mismatch across macOS/Linux/Windows - browser_panes.rs: guard hwnd.0.is_null() behind #[cfg(windows)] to fix compilation on macOS/Linux Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
ReAgent Diagnostics
| Field | Value |
|---|---|
| ReAgent Version | 5.12.5 |
| Trigger | Re-review (new commits) |
| Project Context | CLAUDE.md loaded |
| Model | claude-opus-4-6 |
| Effort | high |
| Ref Repos | Disabled |
| Merge Analysis | 3 regression(s) detected |
| Review Time | 63.4s |
| Timestamp | 2026-04-18T20:14:02Z |
| Repository | agentmuxai/agentmux |
| PR | #444 |
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
platformResolveplugin (.platform.tsx→.darwin/.win32/.linux)Changes
window-controls.darwin.tsxWindowControlsLeftrenders them,WindowControlsRightreturns nullwindow-controls.win32.tsxsystem-status.tsx);WindowControlsRightrenders them,WindowControlsLeftreturns nullwindow-controls.linux.tsxwindow-controls.platform.tsxwindow-controls.darwin.scss#FF5F57/#FFBD2E/#28CA41; glyphs fade in on hoverwindow-controls.win32.scsssystem-status.scss)window-header.tsx<WindowControlsLeft />before<WindowDrag>system-status.tsx<WindowControlsRight />instead of inlinedWindowActionButtonswindow-header.darwin.scss--default-indent: 0px— traffic lights are the left anchorWindows / Linux impact
None. On win32 and linux,
WindowControlsLeftreturnsnull(no extra DOM) andWindowControlsRightrenders the same Win11 buttons as before, just moved fromsystem-status.tsxto the platform file. Thesystem-status.scssWin11 styles moved identically towindow-controls.win32.scss.Test plan
npx tsc --noEmit)🤖 Generated with Claude Code