Skip to content

Conversation

@guanxuc
Copy link
Contributor

@guanxuc guanxuc commented Jan 29, 2026

AgentScope-Java Version

1.0.9

Description

Note

  • Executing unit tests on the windows platform takes 10 minutes, double time longer than ubuntu, which increases CI execution time.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has been formatted with mvn spotless:apply
  • All tests are passing (mvn test)
  • Javadoc comments are complete and follow project conventions
  • Related documentation has been updated (e.g. links, examples, etc.)
  • Code is ready for review

@guanxuc guanxuc requested a review from a team January 29, 2026 09:49
@gemini-code-assist
Copy link

Summary of Changes

Hello @guanxuc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the project's CI pipeline by integrating Windows platform testing, which is crucial for ensuring the application's reliability across different operating systems. It includes necessary adjustments to existing tests to accommodate platform-specific behaviors and updates documentation to reflect current API usage, ultimately contributing to a more stable and well-supported codebase.

Highlights

  • CI Platform Expansion: Added continuous integration (CI) support for the Windows platform, expanding the test coverage and ensuring cross-platform compatibility.
  • Test Stability Improvements: Increased a test timeout in A2aAgentTest from 2 to 5 seconds to prevent flakiness, especially on potentially slower CI environments like Windows. Also, adjusted assertions in ReaderInputTest to be more robust by checking for file names rather than full paths.
  • Documentation Update: Updated documentation examples in both English and Chinese versions of agui.md to use the @AguiAgentId annotation instead of @AguiAgent, reflecting a potential API change or clarification.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/maven-ci.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily focuses on adding CI support for the Windows platform. The changes include increasing a test timeout to improve stability on slower environments and fixing platform-dependent path assertions in tests, which are sensible adjustments for cross-platform compatibility. Additionally, there's a documentation update reflecting an annotation rename. I've suggested a couple of minor improvements to make the test assertions even more robust.

@codecov
Copy link

codecov bot commented Jan 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]:AG-UI 文档与实际代码不一致 [Feature]: Run CI on windows platform

1 participant