Skip to content
This repository was archived by the owner on Jan 23, 2026. It is now read-only.

Enhance Windows MSI upgrade with better fallbacks and error handling#249

Merged
jhaynie merged 1 commit intomainfrom
devin/1745960649-enhance-windows-msi-upgrade
Apr 29, 2025
Merged

Enhance Windows MSI upgrade with better fallbacks and error handling#249
jhaynie merged 1 commit intomainfrom
devin/1745960649-enhance-windows-msi-upgrade

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

Windows MSI Upgrade Enhancement

Similar to PR #244, this PR enhances the Windows MSI upgrade functionality in the agentuity upgrade command to match the behavior in the installer scripts.

Changes

  • Added detection for non-interactive environments (CI, GitHub Actions)
  • Added fallback to copy the MSI installer if automatic installation fails
  • Improved error handling and user feedback
  • Added better messaging for manual installation steps

Testing

  • Code changes have been tested with go test -v ./...
  • Manual testing on Windows is recommended to fully verify the changes

Link to Devin run

https://app.devin.ai/sessions/1dc1a12e734f454aaa7ac2ebb8255baf

Requested by: jhaynie@agentuity.com

Co-Authored-By: jhaynie@agentuity.com <jhaynie@gmail.com>
@devin-ai-integration devin-ai-integration Bot requested a review from jhaynie April 29, 2025 21:07
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Copy link
Copy Markdown
Member

@jhaynie jhaynie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this change work in the case the cli is already installed and handled the case where msiexec fails because the program is already installed?

@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

Yes, this change handles the case where the CLI is already installed in two ways:

  1. First, it runs a PowerShell uninstall script that checks for and removes existing Agentuity installations before attempting to install the new version.

  2. If the installation fails (including the case where msiexec fails because the program is already installed), the code now has a fallback mechanism that:

    • Shows a warning message about the installation failure
    • Copies the MSI installer to the user's home directory
    • Provides instructions for manual installation

The implementation tries multiple installation approaches in sequence:

  1. Direct install with
  2. Update with if direct install fails
  3. Reinstall with , , and if update fails
  4. Fallback to manual installation if all automated approaches fail

This ensures that even if the automatic installation fails for any reason, the user still has a way to complete the upgrade manually.

@jhaynie jhaynie merged commit 3c3dfed into main Apr 29, 2025
12 checks passed
@jhaynie jhaynie deleted the devin/1745960649-enhance-windows-msi-upgrade branch April 29, 2025 21:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant