Devmode: fix issue when using short agentid wasn't going upstream

[jhaynie]

Summary by CodeRabbit

• Bug Fixes
  • Improved handling of agent ID paths to ensure consistent recognition and processing, regardless of whether a full or shortened agent ID is used in the request URL.

[coderabbitai]

Walkthrough

The update refines the handleStream method in the Server struct to standardize incoming request paths. When an agent ID is matched—either in full form or as a shortened version—the request's URL path is rewritten to use the canonical full agent ID with a leading slash, ensuring consistent downstream processing.

Changes

File(s)	Change Summary
internal/dev/server.go	Modified handleStream to rewrite request URL paths to always use the canonical full agent ID with a leading slash.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Server
    participant DownstreamHandler

    Client->>Server: HTTP request (path with agent ID or short form)
    Server->>Server: Match agent ID (full or short)
    Server->>Server: Rewrite URL path to canonical full agent ID
    Server->>DownstreamHandler: Forward request with updated path
    DownstreamHandler-->>Server: Processed response
    Server-->>Client: Response

Loading

Poem

A hop and a skip through the server’s stream,
Paths now align, like a well-oiled machine.
No matter the form—full or short in the race—
Each agent ID finds its canonical place.
With slashes in order, the rabbits all cheer,
For clarity reigns in the code we revere! 🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between f245366 and fc1db75.

📒 Files selected for processing (1)

• internal/dev/server.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: Build and Test (macos-latest)
• GitHub Check: Build and Test (windows-latest)
• GitHub Check: Test CLI Upgrade Path (windows-latest)
• GitHub Check: Analyze (go)
• GitHub Check: Test Install Script (blacksmith-4vcpu-ubuntu-2204)

🔇 Additional comments (1)

internal/dev/server.go (1)

297-300: Good fix for ensuring URL path consistency

This change correctly addresses the issue where using a shortened agent ID (without the "agent_" prefix) wasn't being properly handled. By rewriting the URL path to use the full agent ID with a leading slash, you ensure that downstream code (like the reverse proxy on line 393) consistently works with the canonical agent ID format regardless of how it was initially requested.

The comment is also helpful for explaining the purpose of this change.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.