AGENT-198: Remove Windows from goreleaser build configuration#311
AGENT-198: Remove Windows from goreleaser build configuration#311
Conversation
Co-Authored-By: jhaynie@agentuity.com <jhaynie@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
jhaynie
left a comment
There was a problem hiding this comment.
do we need to update github action workflows to remove windows?
Co-Authored-By: jhaynie@agentuity.com <jhaynie@gmail.com>
Co-Authored-By: jhaynie@agentuity.com <jhaynie@gmail.com>
jhaynie
left a comment
There was a problem hiding this comment.
resolve merge conflicts with main branch
Co-Authored-By: jhaynie@agentuity.com <jhaynie@gmail.com>
|
I'm not sure I agree with this PR. I intentionally not deleted the windows build code from the github actions. We'll use WSL for installing via sh, but a Windows user can still manually download the exe and execute it natively in Windows. |
Co-Authored-By: jhaynie@agentuity.com <jhaynie@gmail.com>
Co-Authored-By: jhaynie@agentuity.com <jhaynie@gmail.com>
… detection message Co-Authored-By: jhaynie@agentuity.com <jhaynie@gmail.com>
…nstallation is not supported Co-Authored-By: jhaynie@agentuity.com <jhaynie@gmail.com>
|
@pec1985 i don't think we want a user to download a windows specific build since we only support WSL right? |
I'm ok with that. Just wanted to bring it up before merging. Approved |
AGENT-198: Remove Windows from goreleaser build configuration
Changes
gooslist under thebuildssectiongoos: windowsandformats: ['zip']) from theformat_overridessectionRationale
We only support Windows via WSL (Windows Subsystem for Linux), which uses the Linux build rather than the Windows-native build. By removing the Windows build target, we'll speed up our build and testing processes.
Testing
go fmt ./...andgo mod tidyLink to Devin run: https://app.devin.ai/sessions/28a88a5dde9f463a8f15cd3a9b41bd16
Requested by: jhaynie@agentuity.com