DevMode: remove mouse tracking as it caused the inability to copy/paste in the terminal#316
DevMode: remove mouse tracking as it caused the inability to copy/paste in the terminal#316
Conversation
…te in the terminal
WalkthroughThe changes remove all dependencies and code related to mouse interaction and the bubblezone package from the TUI component. The log item structure is simplified by eliminating unique IDs and zone marking. The go.mod file is updated to remove the bubblezone dependency, and mouse event handling logic is deleted from the UI. Changes
Poem
Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
internal/dev/tui.go (1)
550-575:⚠️ Potential issuePotential nil-pointer panic when stopping the spinner
SetSpinner(false)unconditionally callsd.spinnerCancel().
If the caller invokesSetSpinner(false)before any precedingSetSpinner(true)(or twice in a row),spinnerCancelis stillniland the program will panic.Proposed safeguard:
-} else { - d.spinnerCancel() - d.spinnerCtx = nil - d.program.Send(spinnerStopMsg{}) +} else if d.spinnerCancel != nil { + d.spinnerCancel() + d.spinnerCtx = nil + d.program.Send(spinnerStopMsg{}) }This keeps existing behaviour while eliminating the panic path.
🧹 Nitpick comments (1)
internal/dev/tui.go (1)
62-70:TitleandFilterValuenow return identical strings – reconsider uniqueness guaranteesAfter removing the
id/zone logic both methods just echomessage.
•list.ModelusesFilterValuewhen searching; duplicate messages will all match, which is fine.
• HoweverTitleis what’s rendered; if several log lines share the same text they will be visually indistinguishable and impossible to select unambiguously once the mouse-zone IDs are gone.If you expect duplicate messages, consider prefixing with the timestamp (or its short form) to keep each row unique and still human-readable.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (2)
go.mod(0 hunks)internal/dev/tui.go(2 hunks)
💤 Files with no reviewable changes (1)
- go.mod
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Test CLI Upgrade Path (windows-latest)
- GitHub Check: Build and Test (windows-latest)
- GitHub Check: Analyze (go)
🔇 Additional comments (1)
internal/dev/tui.go (1)
384-384: LGTM – view rendering works withoutzone.ScanThe new
fmt.Sprintf("%s\n%s\n%s", …)is a clean replacement now that zones are gone.
No functional issues spotted.
2 participants
Summary by CodeRabbit