Filter out env and secrets that are internal

[jhaynie]

Summary by CodeRabbit

• Bug Fixes
  • Environment variables and secrets with keys starting with "AGENTUITY_" are now excluded when updating the project environment, preventing them from being sent in API requests.

[coderabbitai]

Walkthrough

The SetProjectEnv method in the Project struct was updated to exclude environment variables and secrets with keys starting with "AGENTUITY_" before sending them to the API. The method now filters these keys out, using only the remaining entries for the API request. No public interfaces were changed.

Changes

File(s)	Change Summary
internal/project/project.go	Updated SetProjectEnv to filter out env and secret keys with "AGENTUITY_" prefix before API call.

Poem

In the warren of code, a filter appears,
"AGENTUITY_" secrets now disappear.
Only clean keys hop along to the API,
While hidden ones wave a quiet goodbye.
The project stays tidy, the rabbits all cheer!
🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

internal/project/project.go (1)

401-412: Consider extracting the hardcoded prefix to a constant and improving variable naming.

The filtering logic is correct and achieves the intended security goal. However, there are some improvements that could enhance maintainability:

1. The prefix "AGENTUITY_" is hardcoded and duplicated
2. Variable names _env and _secrets are not descriptive
3. The filtering logic is duplicated between env and secrets

Consider this refactor for better maintainability:

+const internalEnvPrefix = "AGENTUITY_"
+
+func filterInternalKeys(input map[string]string) map[string]string {
+	filtered := make(map[string]string)
+	for k, v := range input {
+		if !strings.HasPrefix(k, internalEnvPrefix) {
+			filtered[k] = v
+		}
+	}
+	return filtered
+}
+
 func (p *Project) SetProjectEnv(ctx context.Context, logger logger.Logger, baseUrl string, token string, env map[string]string, secrets map[string]string) (*ProjectData, error) {
 	client := util.NewAPIClient(ctx, logger, baseUrl, token)
 	var projectResponse ProjectResponse
-	_env := make(map[string]string)
-	for k, v := range env {
-		if !strings.HasPrefix(k, "AGENTUITY_") {
-			_env[k] = v
-		}
-	}
-	_secrets := make(map[string]string)
-	for k, v := range secrets {
-		if !strings.HasPrefix(k, "AGENTUITY_") {
-			_secrets[k] = v
-		}
-	}
+	filteredEnv := filterInternalKeys(env)
+	filteredSecrets := filterInternalKeys(secrets)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4e4caad and 04a9871.

📒 Files selected for processing (1)

• internal/project/project.go (1 hunks)

🔇 Additional comments (1)

internal/project/project.go (1)

414-415: Approve the use of filtered maps in API payload.

The filtered maps are correctly used in the API call, ensuring that internal environment variables and secrets are not exposed to external systems.