Skip to content
This repository was archived by the owner on Jan 23, 2026. It is now read-only.

Switch to using a more compatible docker internal hostname that works cross platform#394

Merged
jhaynie merged 1 commit intomainfrom
fix-hostname
Jun 18, 2025
Merged

Switch to using a more compatible docker internal hostname that works cross platform#394
jhaynie merged 1 commit intomainfrom
fix-hostname

Conversation

@jhaynie
Copy link
Copy Markdown
Member

@jhaynie jhaynie commented Jun 18, 2025

Summary by CodeRabbit

  • Bug Fixes

    • Updated URL transformation to use "host.docker.agentuity.io" instead of "host.docker.internal" for local development scenarios, ensuring consistent access when running inside containers.
  • Tests

    • Adjusted test cases to reflect the updated host in transformed URLs, improving test accuracy for local development environments.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 18, 2025

Walkthrough

The TransformUrl function was updated to replace any instance of "host.docker.internal" with "host.docker.agentuity.io" in URLs used for local development within containers. Corresponding test cases were modified to expect the new host in transformed URLs. No changes were made to exported or public entity declarations.

Changes

File(s) Change Summary
internal/util/api.go Updated TransformUrl to replace "host.docker.internal" with "host.docker.agentuity.io" in URLs.
internal/util/api_test.go Modified test expectations to use the new host "host.docker.agentuity.io" in transformed URLs.

Poem

A hop and a skip, the URLs now glow,
From "docker.internal" to "agentuity.io"!
Containers rejoice, the tests all agree,
The rabbit approves, as happy as can be.
🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate Unit Tests
  • Create PR with Unit Tests
  • Post Copyable Unit Tests in Comment
  • Commit Unit Tests in branch fix-hostname

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai auto-generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
internal/util/api.go (2)

245-245: Duplication of docker host string
The hostname "host.docker.agentuity.io" is repeated in multiple branches. Extract this value (and the default port values) into package-level constants to keep the code DRY and simplify future updates.


249-249: Use URL parsing instead of regex for port extraction
Rather than matching :(\d+) on the raw urlString, parse the URL once and call u.Port()—this is more robust and clearer.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 61c639c and 12983f7.

📒 Files selected for processing (2)
  • internal/util/api.go (1 hunks)
  • internal/util/api_test.go (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: Build and Test (macos-latest)
  • GitHub Check: Test CLI Upgrade Path (windows-latest)
  • GitHub Check: Analyze (go)
🔇 Additional comments (2)
internal/util/api.go (1)

251-251: Hardcoded fallback port
Always defaulting to :3000 could miss custom ports in certain setups. Verify if this meets all scenarios or consider making the default port configurable (or dynamically derived).

internal/util/api_test.go (1)

27-30: Align test expectations with updated docker host
The test cases correctly expect "host.docker.agentuity.io" in transformed URLs, matching the updated TransformUrl logic.

@jhaynie jhaynie merged commit e995e5e into main Jun 18, 2025
14 checks passed
@jhaynie jhaynie deleted the fix-hostname branch June 18, 2025 17:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant