Conversation
Change upgrade completion message from ShowWarning to ShowSuccess to display with green checkmark instead of red X when CLI is upgraded. Fixes the confusing error-style message that appeared when the upgrade actually succeeded. Co-Authored-By: Rick Blalock <rickblalock@mac.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Join our Discord community for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Fix upgrade success message styling
Summary
Changes the CLI upgrade completion message from
tui.ShowWarning()totui.ShowSuccess()to display with a green checkmark instead of a red X when the CLI is successfully upgraded.Problem: When the CLI is upgraded, users see a confusing red error-style message saying "Agentuity CLI was upgraded. Please re-run the command again to continue." even though the upgrade actually succeeded.
Solution: Changed the message styling from
ShowWarningtoShowSuccessincmd/root.go:220to align with the success nature of the message and match other upgrade success messages in the codebase.Review & Testing Checklist for Human
checkForUpgrade()was the one appearing as a red X in the original bug reportDiagram
graph TD A[cmd/root.go] --> B[checkForUpgrade function] B --> C[util.CheckLatestRelease] C --> D{Upgrade needed?} D -->|Yes| E[tui.ShowSuccess - CHANGED] D -->|No| F[Continue normally] G[internal/util/upgrade.go] --> H[UpgradeCLI function] H --> I[tui.ShowSuccess messages] J[internal/bundler/groq.go] --> K[Minor formatting change] A:::major-edit J:::minor-edit G:::context subgraph Legend L1[Major Edit]:::major-edit L2[Minor Edit]:::minor-edit L3[Context/No Edit]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#ADD8E6 classDef context fill:#FFFFFFNotes
internal/util/upgrade.goalready usestui.ShowSuccessfor upgrade completion)internal/bundler/groq.gofromgo fmtLink to Devin run: https://app.devin.ai/sessions/8b6a8622df794795976bb1e3999ff9e6
Requested by: @rblalock