Skip to content
This repository was archived by the owner on Jan 23, 2026. It is now read-only.

Fix upgrade success message styling#404

Merged
jhaynie merged 1 commit intomainfrom
devin/1751046195-fix-upgrade-success-message
Jun 30, 2025
Merged

Fix upgrade success message styling#404
jhaynie merged 1 commit intomainfrom
devin/1751046195-fix-upgrade-success-message

Conversation

@devin-ai-integration
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot commented Jun 27, 2025

Fix upgrade success message styling

Summary

Changes the CLI upgrade completion message from tui.ShowWarning() to tui.ShowSuccess() to display with a green checkmark instead of a red X when the CLI is successfully upgraded.

Problem: When the CLI is upgraded, users see a confusing red error-style message saying "Agentuity CLI was upgraded. Please re-run the command again to continue." even though the upgrade actually succeeded.

Solution: Changed the message styling from ShowWarning to ShowSuccess in cmd/root.go:220 to align with the success nature of the message and match other upgrade success messages in the codebase.

Review & Testing Checklist for Human

  • Test the upgrade flow end-to-end - Trigger a CLI upgrade and verify the message now displays with green success styling instead of red warning styling
  • Verify this was the correct message location - Confirm this specific message in checkForUpgrade() was the one appearing as a red X in the original bug report
  • Check message semantics - Ensure the message content still makes sense as a "success" message rather than a "warning"

Diagram

graph TD
    A[cmd/root.go] --> B[checkForUpgrade function]
    B --> C[util.CheckLatestRelease]
    C --> D{Upgrade needed?}
    D -->|Yes| E[tui.ShowSuccess - CHANGED]
    D -->|No| F[Continue normally]
    
    G[internal/util/upgrade.go] --> H[UpgradeCLI function]
    H --> I[tui.ShowSuccess messages]
    
    J[internal/bundler/groq.go] --> K[Minor formatting change]
    
    A:::major-edit
    J:::minor-edit
    G:::context
    
    subgraph Legend
        L1[Major Edit]:::major-edit
        L2[Minor Edit]:::minor-edit  
        L3[Context/No Edit]:::context
    end
    
    classDef major-edit fill:#90EE90
    classDef minor-edit fill:#ADD8E6
    classDef context fill:#FFFFFF
Loading

Notes

  • This change aligns the upgrade completion message with other success messages in the upgrade flow (internal/util/upgrade.go already uses tui.ShowSuccess for upgrade completion)
  • The message content remains unchanged, only the styling (color/icon) changes from warning (red X) to success (green checkmark)
  • Also includes a minor formatting change to internal/bundler/groq.go from go fmt

Link to Devin run: https://app.devin.ai/sessions/8b6a8622df794795976bb1e3999ff9e6

Requested by: @rblalock

Change upgrade completion message from ShowWarning to ShowSuccess
to display with green checkmark instead of red X when CLI is upgraded.

Fixes the confusing error-style message that appeared when the
upgrade actually succeeded.

Co-Authored-By: Rick Blalock <rickblalock@mac.com>
@devin-ai-integration
Copy link
Copy Markdown
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 27, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jhaynie jhaynie merged commit 7a6fec6 into main Jun 30, 2025
14 checks passed
@jhaynie jhaynie deleted the devin/1751046195-fix-upgrade-success-message branch June 30, 2025 14:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants