Bun: re-generate the lock file when we go to install for the first time or in CI

[jhaynie]

Summary by CodeRabbit

• Bug Fixes
  • Improved reliability for Bun-based JavaScript projects by ensuring the lockfile is updated before installing dependencies, reducing errors related to outdated lockfiles.

[coderabbitai]

Walkthrough

A new function, generateBunLockfile, was introduced to update the Bun lockfile by running bun install --lockfile-only in a given directory. The bundleJavascript function was modified to call this new function before installing dependencies when handling the "bunjs" runtime, ensuring the lockfile is current.

Changes

File(s)	Change Summary
internal/bundler/bundler.go	Added generateBunLockfile function; updated bundleJavascript to use it for "bunjs" runtime before dependency installation.

Poem

A lockfile fresh, a bunny’s quest,
With Bun in tow, we do our best.
Before install, we pause and check—
The lockfile’s new, no need to fret!
With careful steps, the code will run,
A tidy warren—job well done! 🐇✨

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch regen-lock

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai auto-generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

internal/bundler/bundler.go (1)

144-154: Simplify function signature by removing redundant logger parameter.

The function accepts a logger.Logger parameter but it's always called with ctx.Logger. Since the function already has access to the BundleContext, this parameter is redundant and adds unnecessary complexity.

Apply this diff to simplify the function signature:

-func generateBunLockfile(ctx BundleContext, logger logger.Logger, dir string) error {
+func generateBunLockfile(ctx BundleContext, dir string) error {
 	args := []string{"install", "--lockfile-only"}
 	install := exec.CommandContext(ctx.Context, "bun", args...)
 	install.Dir = dir
 	out, err := install.CombinedOutput()
 	if err != nil {
 		return fmt.Errorf("failed to generate bun lockfile: %w. %s", err, string(out))
 	}
-	logger.Debug("re-generated bun lockfile: %s", strings.TrimSpace(string(out)))
+	ctx.Logger.Debug("re-generated bun lockfile: %s", strings.TrimSpace(string(out)))
 	return nil
 }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6312321 and 96e5c60.

📒 Files selected for processing (1)

• internal/bundler/bundler.go (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

• GitHub Check: Test CLI Upgrade Path (windows-latest)
• GitHub Check: Test CLI Upgrade Path (blacksmith-4vcpu-ubuntu-2204-arm)
• GitHub Check: Test CLI Upgrade Path (blacksmith-4vcpu-ubuntu-2204)
• GitHub Check: Build and Test (blacksmith-4vcpu-ubuntu-2204-arm)
• GitHub Check: Build and Test (blacksmith-4vcpu-ubuntu-2204)
• GitHub Check: Build and Test (macos-latest)
• GitHub Check: Analyze (go)
• GitHub Check: Analyze (actions)

🔇 Additional comments (1)

internal/bundler/bundler.go (1)

164-168: LGTM! Well-integrated lockfile generation call.

The placement of the generateBunLockfile call before the actual bun install command is appropriate and aligns with the PR objective. The explanatory comments clearly document why this step is necessary. Error handling is properly implemented with early return on failure.

Note: Update the function call if you apply the suggested refactor above:

-		if err := generateBunLockfile(ctx, ctx.Logger, dir); err != nil {
+		if err := generateBunLockfile(ctx, dir); err != nil {