Skip to content
This repository was archived by the owner on Jan 23, 2026. It is now read-only.

Add curl cmd as mac fallback installation method #419

Closed
potofpie wants to merge 2 commits into from
Closed

Add curl cmd as mac fallback installation method #419

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
718f284
not sure if this is right but maybe
potofpie Jul 15, 2025
5adc0c4
Merge branch 'main' into install-script-change
potofpie Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,12 @@ install_mac() {
fi

else
ohai "Installing Agentuity CLI using curl..."
ohai "Installing Agentuity CLI using curl..."
# Use the overridable CURL var, abort on error, and stop this script afterwards
if ! "$CURL" -fsSL https://agentuity.sh | sh; then
abort "cURL installation failed. Please check your connection or try --no-brew again."
fi
Comment on lines +238 to +240
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Jul 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Pipeline can silently succeed even when curl fails – add set -o pipefail.

Without pipefail, the exit status of the pipeline is that of sh, not curl.
If curl fails (e.g., network error, 404), sh happily consumes nothing and exits 0, so the abort branch is never taken.

@@
-set -e
+# Abort on errors *and* on any component of a pipe failing
+set -e
+set -o pipefail

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents 
In install.sh around lines 238 to 240, the pipeline using curl and sh can
silently succeed if curl fails because the exit status reflects sh's success,
not curl's. To fix this, add 'set -o pipefail' before the pipeline command to
ensure the script detects failures in any part of the pipeline, causing the
abort branch to trigger correctly on curl errors.

success # print final message & exit 0
fi

}
Expand Down
Loading