Skip to content

feat: preserve opaque SP1 proof payloads in interop#202

Merged
Freyskeyd merged 4 commits intomainfrom
refactor/adding-versionning-to-aggchaindata
Apr 14, 2026
Merged

feat: preserve opaque SP1 proof payloads in interop#202
Freyskeyd merged 4 commits intomainfrom
refactor/adding-versionning-to-aggchaindata

Conversation

@Freyskeyd
Copy link
Copy Markdown
Member

Summary

  • store Proof::SP1Stark payloads as raw version/proof/vkey bytes in interop types instead of typed SP1 Rust values
  • preserve opaque SP1 payload bytes across compat v1 protobuf conversions and keep optional public_values context handling consistent
  • add serde and bincode envelope round-trip coverage plus explicit opaque payload tests for v4.0.0-rc.3 and v6.0.0

Test Plan

  • cargo test -p agglayer-interop-types --features testutils
  • cargo test -p agglayer-interop-grpc-types --features compat

Keep SP1 proof envelopes opaque in interop and preserve version/proof/vkey bytes through compat round-trips. This avoids deserialization breakage across SP1 upgrades while adding explicit round-trip coverage for older and newer payloads.
Drop workspace-level SP1 crates that are no longer referenced after interop stopped depending on typed SP1 proof types. Keep the smaller remaining SP1 footprint for ELF build tooling and the agglayer-bincode test.
@Freyskeyd Freyskeyd marked this pull request as ready for review April 10, 2026 06:23
@Freyskeyd Freyskeyd requested a review from a team as a code owner April 10, 2026 06:23
@Freyskeyd
Copy link
Copy Markdown
Member Author

@claude review-once

@Freyskeyd Freyskeyd changed the title Preserve opaque SP1 proof payloads in interop feat: preserve opaque SP1 proof payloads in interop Apr 13, 2026
Copy link
Copy Markdown
Collaborator

@Ekleog-Polygon Ekleog-Polygon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Keeping the SP1 payload opaque makes sense to me.

Comment thread crates/agglayer-interop-types/src/aggchain_proof/mod.rs
@Freyskeyd Freyskeyd added this pull request to the merge queue Apr 14, 2026
Merged via the queue into main with commit 463d36a Apr 14, 2026
15 checks passed
@Freyskeyd Freyskeyd deleted the refactor/adding-versionning-to-aggchaindata branch April 14, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants