Skip to content

fix: reject overflowing multisig signer indexes in gRPC compat decode#217

Open
Ekleog-Polygon wants to merge 2 commits intomainfrom
interop-214
Open

fix: reject overflowing multisig signer indexes in gRPC compat decode#217
Ekleog-Polygon wants to merge 2 commits intomainfrom
interop-214

Conversation

@Ekleog-Polygon
Copy link
Copy Markdown
Collaborator

Summary

  • reject u32::MAX multisig signer indexes in v1 gRPC compat decode with the typed Multisig ECDSA signer index overflow error
  • keep the decode path from panicking in debug and test builds by using checked arithmetic when sizing the signer vector
  • add a regression test that asserts the overflow case returns the exact invalid-data error

Testing

  • cargo test -p agglayer-interop-grpc-types

Fixes #214

Return a typed invalid-data error for u32::MAX signer indexes so compat decode does not panic in debug or test builds.
@Ekleog-Polygon Ekleog-Polygon marked this pull request as ready for review April 16, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Avoid multisig signer index overflow panic in gRPC compat decode

2 participants