refactor(dir): add google.rpc.Status for error messages#1064
Draft
csirmazbendeguz wants to merge 1 commit intomainfrom
Draft
refactor(dir): add google.rpc.Status for error messages#1064csirmazbendeguz wants to merge 1 commit intomainfrom
csirmazbendeguz wants to merge 1 commit intomainfrom
Conversation
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / verify-proto (pull_request).
|
csirmazbendeguz
force-pushed
the
refactor/google-status
branch
5 times, most recently
from
1c33f52 to
38cc00b
Compare
2 tasks
csirmazbendeguz
force-pushed
the
refactor/google-status
branch
2 times, most recently
from
a483aa3 to
16bb2b8
Compare
Signed-off-by: Bendegúz Csirmaz <csirmazbendeguz@gmail.com>
csirmazbendeguz
force-pushed
the
refactor/google-status
branch
from
16bb2b8 to
24d7a33
Compare
Contributor
Author
|
it looks like googleapis doesn't support protobuf 7 yet so this PR is blocked |
ramizpolic
reviewed
Mar 24, 2026
Comment on lines
+59
to
+61
| // success, error_message was removed in favor of error | ||
| reserved 1, 2; | ||
| reserved "success", "error_message"; |
Member
There was a problem hiding this comment.
no need to keep gRPC contracts compatible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1059
As per https://google.aip.dev/193 , we should use
google.rpc.Statusinstead of fields likesuccessorerror_message