Skip to content

Feat: implement the processor server#4263

Open
lacroixthomas wants to merge 6 commits intoagones-dev:mainfrom
lacroixthomas:features/implement-processor-server
Open

Feat: implement the processor server#4263
lacroixthomas wants to merge 6 commits intoagones-dev:mainfrom
lacroixthomas:features/implement-processor-server

Conversation

@lacroixthomas
Copy link
Copy Markdown
Collaborator

@lacroixthomas lacroixthomas commented Sep 2, 2025

What type of PR is this?
/kind feature

What this PR does / Why we need it:

Implementation of the processor server behind dev feature flag

TODO (some might be on another MR):

  • New Metrics ? (Other PR)
  • TLS ? Is it needed ? (Other PR)
  • Unit tests

Which issue(s) this PR fixes:
Part of #4190

Special notes for your reviewer:
Opening the draft for early feedbacks

@github-actions github-actions Bot added kind/feature New features for Agones size/XL labels Sep 2, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 2, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 2, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 0dfb8b31-e31f-4756-9245-fc6a5ef6c6fe

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@lacroixthomas
Copy link
Copy Markdown
Collaborator Author

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: be7478b2-5c1c-498c-8498-6d3e35aaedb5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4263/head:pr_4263 && git checkout pr_4263
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-3b0ba99

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 4, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

1 similar comment
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 4, 2025

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 91746f34-8ce0-429a-b492-139ab1d0e898

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@lacroixthomas
Copy link
Copy Markdown
Collaborator Author

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: e64c3f64-8657-4721-8904-83a4c840bd47

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4263/head:pr_4263 && git checkout pr_4263
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-6dec885

@github-actions github-actions Bot added the size/L label Sep 7, 2025
@agones-bot
Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: 1241bbbd-7bde-46ec-95ec-3b8712be910f

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4263/head:pr_4263 && git checkout pr_4263
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.52.0-dev-6351400

@lacroixthomas lacroixthomas force-pushed the features/implement-processor-server branch from 6351400 to c239fdb Compare October 22, 2025 21:02
Comment thread install/helm/agones/templates/processor.yaml Outdated
@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 97a4c8b6-9fdc-444b-8694-653b14e80797

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 04dff753-1c63-4882-bb56-0f2ec1158e07

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 4aa098c0-e599-4386-8bd8-7f51ecf4034f

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@lacroixthomas lacroixthomas force-pushed the features/implement-processor-server branch from 56cf40e to de22bdc Compare November 19, 2025 22:36
@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 0e0967ca-55e6-4012-9f36-c8c00cf9108c

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@lacroixthomas
Copy link
Copy Markdown
Collaborator Author

I'll come back to this task in the next days / week, didn't forget about it !

@lacroixthomas lacroixthomas force-pushed the features/implement-processor-server branch from de22bdc to 3078f81 Compare December 3, 2025 23:31
@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: af923d1a-67cc-48c6-9039-634cda0feb28

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@lacroixthomas lacroixthomas force-pushed the features/implement-processor-server branch from 3078f81 to ddd9a28 Compare December 17, 2025 23:05
@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 1c732008-568e-45a8-9455-40c393278ecd

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@github-actions
Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 792e8178-8cf5-4479-b4f8-1f6dbd845439

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@lacroixthomas lacroixthomas force-pushed the features/implement-processor-server branch from 87c55c4 to 2518c80 Compare December 20, 2025 20:48
@github-actions
Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

1 similar comment
@github-actions
Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: c372a81b-0391-429f-b9ff-cded5cc183ef

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@lacroixthomas lacroixthomas force-pushed the features/implement-processor-server branch from e913afe to b8afb1f Compare April 22, 2026 23:37
@github-actions
Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@lacroixthomas lacroixthomas force-pushed the features/implement-processor-server branch from b8afb1f to 4aa4f7a Compare April 22, 2026 23:43
@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 2837e3a4-9e0d-49a0-8430-e909d5f57f93

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@github-actions
Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@lacroixthomas lacroixthomas force-pushed the features/implement-processor-server branch from 4aa4f7a to b81a88c Compare April 22, 2026 23:45
@github-actions
Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 064cc2e7-70db-4e45-99af-50093b9d8598

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

lacroixthomas and others added 3 commits April 22, 2026 20:05
feat: add metrics setup for processor

feat: remove exit from sigterm and let it shutdown gracefully

feat: fix conflicts

feat: update logs

feat: test pipeline with ProcessorAllocator in alpha

feat: test pipeline with ProcessorAllocator in alpha

feat: debug e2e failing

feat: debug e2e failing

feat: fix error handling and feature gate from dep env

feat: fix extension and allocator with processor server

feat: update unit test

feat: add missing status

feat: fix missing namespace

feat: refactor a bit the error handling

feat: update copyright to 2026

feat: minor changes

feat: rollback unit test fix (other PR)

feat: fix rebase issue

feat: fix unit test from rebase
Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>
Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>
Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>
@lacroixthomas lacroixthomas force-pushed the features/implement-processor-server branch from b81a88c to 3cb0bf7 Compare April 23, 2026 00:12
@github-actions
Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@github-actions
Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: bb9fb1b7-85c6-41de-b23b-9aa5455735bb

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>
@github-actions
Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@lacroixthomas
Copy link
Copy Markdown
Collaborator Author

Note to myself: Remember to rollback the feature gate to dev *

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: f5dbaa56-93d4-49e2-9397-eab4ed9a534f

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@lacroixthomas
Copy link
Copy Markdown
Collaborator Author

I think I already seen this error :(

Step #2 - "e2e-stable": VERBOSE: time="2026-04-23 01:28:14.554" level=info msg="checking if GameServer exists" error="client rate limiter Wait returned an error: context deadline exceeded" gs=game-serverppbms state= test=TestGameServerPodCompletedAfterCleanExit
Step #2 - "e2e-stable": VERBOSE:     gameserver_test.go:549: 
Step #2 - "e2e-stable": VERBOSE:         	Error Trace:	/go/src/agones.dev/agones/test/e2e/gameserver_test.go:549
Step #2 - "e2e-stable": VERBOSE:         	Error:      	Received unexpected error:
Step #2 - "e2e-stable": VERBOSE:         	            	client rate limiter Wait returned an error: context deadline exceeded
Step #2 - "e2e-stable": VERBOSE:         	Test:       	TestGameServerPodCompletedAfterCleanExit
Step #2 - "e2e-stable": VERBOSE: --- FAIL: TestGameServerPodCompletedAfterCleanExit (303.14s)

/gcbrun

@lacroixthomas
Copy link
Copy Markdown
Collaborator Author

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: 37b2d46e-0901-4163-bb8b-1013d9f5be5c

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4263/head:pr_4263 && git checkout pr_4263
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.58.0-dev-5dca72f

Signed-off-by: Thomas Lacroix <thomas.lacroix@epitech.eu>
@github-actions
Copy link
Copy Markdown

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@lacroixthomas
Copy link
Copy Markdown
Collaborator Author

lacroixthomas commented Apr 23, 2026

@markmandel The e2e that were passing here were using the processorAllocator=true for the featureGate as Alpha
#4263 (comment)

I just rolled that back to dev, should be all good now 😄 🤞🏼

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Succeeded 🥳

Build Id: c070fe74-7356-4b1c-9543-c040ee0d3947

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

git fetch https://github.com/googleforgames/agones.git pull/4263/head:pr_4263 && git checkout pr_4263
helm install agones ./install/helm/agones --namespace agones-system --set agones.image.registry=us-docker.pkg.dev/agones-images/ci --set agones.image.tag=1.58.0-dev-ab34181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/feature New features for Agones size/L size/XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants