Add env option to all Agones component deployments#4499
Add env option to all Agones component deployments#4499lazy-slackoth wants to merge 4 commits intoagones-dev:mainfrom
Conversation
|
I like it!
/gcbrun |
|
Just a gentle bump to see if you would like to round out this PR? |
|
Yes,sure |
lazy-slackoth
force-pushed
the
feature/add-custom-env-vars
branch
from
4785c53 to
c634e39
Compare
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
lazy-slackoth
force-pushed
the
feature/add-custom-env-vars
branch
2 times, most recently
from
ab331fe to
6ffb6b1
Compare
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
lazy-slackoth
force-pushed
the
feature/add-custom-env-vars
branch
2 times, most recently
from
19f0236 to
7a05c96
Compare
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Signed-off-by: Alexander Taran <a.taran@strikerz.inc>
Signed-off-by: Alexander Taran <a.taran@strikerz.inc>
lazy-slackoth
force-pushed
the
feature/add-custom-env-vars
branch
from
7a05c96 to
d1b609b
Compare
Signed-off-by: Alexander Taran <a.taran@strikerz.inc>
|
From my side, it seems to be ready |
| | `agones.controller.mutatingWebhook.disableCaBundle` | **Deprecated**. Use `agones.extensions.mutatingWebhook.disableCaBundle` instead. Disable ca-bundle so it can be injected by cert-manager | `false` | | ||
| | `agones.controller.allocationBatchWaitTime` | Wait time between each allocation batch when performing allocations in controller mode | `500ms` | | ||
| | `agones.controller.topologySpreadConstraints` | Ensures better resource utilization and high availability by evenly distributing Pods in the agones-system namespace | `{}` | | ||
| | `agones.controller.env` | Additional [environment variables](https://kubernetes.io/docs/tasks/inject-data-application/define-environment-variable-container/) to inject into the controller pod | `[]` | |
There was a problem hiding this comment.
Thanks for the docs, but these need to be feature shortcoded:
https://agones.dev/site/docs/contribute/documentation-editing-contribution/#within-a-page
This is because docs publish immediately, not on release 👍🏻
You may also need to duplicate the whole table, since shortcodes don't work so great when in the middle of tables.
2 participants
What type of PR is this?
What this PR does / Why we need it:
Adds an env field to each Agones component in values.yaml (controller, extensions, ping, allocator, allocator.processor), allowing users to inject arbitrary environment variables into any deployment. The full Kubernetes env var spec is supported (value, valueFrom, secretKeyRef, configMapKeyRef, fieldRef, etc.). Custom vars are appended after the built-in ones.