Skip to content

chore: update copyright header to CNCF format in proto directory#4525

Open
JeevaRamanathan wants to merge 5 commits intoagones-dev:mainfrom
JeevaRamanathan:cncf-license-headers/protos
Open

chore: update copyright header to CNCF format in proto directory#4525
JeevaRamanathan wants to merge 5 commits intoagones-dev:mainfrom
JeevaRamanathan:cncf-license-headers/protos

Conversation

@JeevaRamanathan
Copy link
Copy Markdown
Contributor

Summary

Updates Apache License old copyright headers to Copyright Contributors to Agones a Series of LF Projects, LLC. as per the CNCF Copyright Notices guidelines.

This PR covers Go source files in the proto/ directory covering 12 files.

Closes partially: #4514

Test plan

  • Verified all old copyright headers in target directories have been replaced
  • Verified no other lines were modified (each file has exactly headers line changed)
  • Both comment styles handled: // and /* */

Signed-off-by: JeevaRamanathan <jeevaramanathan.m@infosys.com>
@igooch
Copy link
Copy Markdown
Collaborator

igooch commented Apr 20, 2026

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 92736138-25f6-406d-9be6-0b164feeeefa

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@igooch
Copy link
Copy Markdown
Collaborator

igooch commented Apr 20, 2026

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: e26a971e-2f5c-40eb-92c8-28bbbcb48257

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

Copy link
Copy Markdown
Collaborator

@igooch igooch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try running make gen-all-sdk-grpc

@markmandel
Copy link
Copy Markdown
Member

/gcbrun

I'm kinda curious if the current set of copyright notice updates may have kinda solved this failure 😄

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: ba296277-de72-4d9a-828c-2de8d2c99a81

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Copy Markdown
Member

Yeah, this will need a make gen-all-sdk-grpc and then push back up with the updates.

Signed-off-by: Mark Mandel <mark@compoundtheory.com>
@markmandel markmandel force-pushed the cncf-license-headers/protos branch from 88512fd to 012ac61 Compare April 26, 2026 00:59
@markmandel
Copy link
Copy Markdown
Member

Hope you don't mind 😄 I took the liberty of running make gen-all-sdk-grpc since it takes a while and builds a stack of docker images.

@markmandel
Copy link
Copy Markdown
Member

/gcbrun

@markmandel markmandel requested a review from a team April 26, 2026 01:09
@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 88e4cd26-23f5-433a-9968-0e3f6b9465a6

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Copy Markdown
Member

Flake:
https://console.cloud.google.com/cloud-build/builds/18b1a2c5-8574-42b7-b6cf-191b20ac89d5;step=1?project=agones-images

VERBOSE: time="2026-04-26 01:43:16.501" level=info msg="Checking Fleet Ready replicas" expected=150 fleet=preferred-dvl8g fleetStatus="{Replicas:150 ReadyReplicas:150 ReservedReplicas:0 AllocatedReplicas:0 Players:0xc0004ec420 Counters:map[] Lists:map[]}" test=TestGameServerAllocationDuringMultipleAllocationClients
VERBOSE: time="2026-04-26 01:43:16.502" level=info msg="Scaling fleet" fleet=preferred-dvl8g patch="[{ \"op\": \"replace\", \"path\": \"/spec/replicas\", \"value\": 130 }]" scale=130
VERBOSE: time="2026-04-26 01:43:16.620" level=info msg="Starting 100 allocation attempts" test=TestGameServerAllocationDuringMultipleAllocationClients
VERBOSE: time="2026-04-26 01:43:17.621" level=info msg="Scaling Fleet down by 10 replicas" test=TestGameServerAllocationDuringMultipleAllocationClients
VERBOSE: time="2026-04-26 01:43:17.621" level=info msg="Scaling fleet" fleet=preferred-dvl8g patch="[{ \"op\": \"replace\", \"path\": \"/spec/replicas\", \"value\": 120 }]" scale=120
VERBOSE: time="2026-04-26 01:43:18.975" level=info msg="Allocation error: an error on the server (\"could not update the selected GameServer\") has prevented the request from succeeding (post gameserverallocations.allocation.agones.dev)" test=TestGameServerAllocationDuringMultipleAllocationClients
VERBOSE: I0426 01:43:19.022727   10614 request.go:752] "Waited before sending request" delay="1.053439727s" reason="client-side throttling, not priority and fairness" verb="POST" URL="https://35.237.51.105/apis/allocation.agones.dev/v1/namespaces/1777167759/gameserverallocations"
VERBOSE: time="2026-04-26 01:43:27.000" level=info msg="Allocation error: an error on the server (\"could not update the selected GameServer\") has prevented the request from succeeding (post gameserverallocations.allocation.agones.dev)" test=TestGameServerAllocationDuringMultipleAllocationClients
VERBOSE: I0426 01:43:29.222652   10614 request.go:752] "Waited before sending request" delay="1.241340261s" reason="client-side throttling, not priority and fairness" verb="POST" URL="https://35.237.51.105/apis/allocation.agones.dev/v1/namespaces/1777167759/gameserverallocations"
VERBOSE: time="2026-04-26 01:43:29.519" level=info msg="Allocation error: an error on the server (\"could not update the selected GameServer\") has prevented the request from succeeding (post gameserverallocations.allocation.agones.dev)" test=TestGameServerAllocationDuringMultipleAllocationClients
VERBOSE: time="2026-04-26 01:43:35.059" level=info msg="Finished allocation attempts" test=TestGameServerAllocationDuringMultipleAllocationClients
VERBOSE:     gameserverallocation_test.go:1479: Test failed: Less than 98 GameServers were allocated. Allocated: 97
VERBOSE: --- FAIL: TestGameServerAllocationDuringMultipleAllocationClients (54.82s)

/gcbrun

@markmandel
Copy link
Copy Markdown
Member

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: f1491641-e6a7-4e50-8268-d039f361e0c3

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Copy Markdown
Member

/gcbrun

@agones-bot
Copy link
Copy Markdown
Collaborator

Build Failed 😭

Build Id: 21b4ccba-705b-49c4-8123-0ae746254fd5

Status: FAILURE

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel
Copy link
Copy Markdown
Member

/gcbrun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants