Skip to content

fix: ensure CI fails when pytest fails by adding pipefail #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lauty95 wants to merge 3 commits into
base: version-15
Choose a base branch
from
Open

fix: ensure CI fails when pytest fails by adding pipefail #339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6db0c3
fix: ensure CI fails when pytest fails by adding pipefail
lauty95 Apr 9, 2026
ecc73c9
fix: target with uom
lauty95 Apr 16, 2026
30226ec
fix: linters
lauty95 Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/pytest.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ jobs:
- name: Run Tests
working-directory: /home/runner/frappe-bench
run: |
set -o pipefail
source env/bin/activate
cd apps/beam
poetry install
Expand Down
2 changes: 2 additions & 0 deletions beam/beam/scan/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,10 +279,12 @@ def get_form_action(barcode_doc: frappe._dict, context: frappe._dict) -> list[di
elif has_frm_override:
# A beam_frm override handles this form — skip get_item_details() which would
# fail for forms without a standard "{doctype} Item" child table.
item_defaults = frappe.db.get_value("Item", barcode_doc.doc.name, ["stock_uom"], as_dict=True)
target = frappe._dict(
{
"doctype": context.frm,
"item_code": barcode_doc.doc.name,
"uom": item_defaults.stock_uom if item_defaults else None,
}
)
else:
Expand Down
Loading