[atable] add row-click and row-open event emitters#356
Draft
Alchez wants to merge 6 commits intodevelopmentfrom
Draft
[atable] add row-click and row-open event emitters#356Alchez wants to merge 6 commits intodevelopmentfrom
Alchez wants to merge 6 commits intodevelopmentfrom
Conversation
Alchez
commented
Mar 4, 2026
Collaborator
Author
There was a problem hiding this comment.
@agritheory this is something that Claude generated based on the other icons, but we should have a proper design for it
Contributor
Coverage Report for atable
File Coverage |
Contributor
Coverage Report for stonecrop
File Coverage |
Contributor
Coverage Report for aform
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Owner
|
@crabinak Let's add an "Internal link" and "external link" icon to cover these cases (right-pointing arrow and top-right-point arrow) |
Owner
|
@Alchez Rename "Open row" to "open record" to disambiguate from "expand row" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This came up because FAB needed to handle row-click events, and it was using workarounds using a container
divelement.There's two new stories in the ATable section for clickable and open-able table rows.