Skip to content

[atable] add row-click and row-open event emitters#356

Draft
Alchez wants to merge 6 commits intodevelopmentfrom
fix-atable-row-click-open
Draft

[atable] add row-click and row-open event emitters#356
Alchez wants to merge 6 commits intodevelopmentfrom
fix-atable-row-click-open

Conversation

@Alchez
Copy link
Copy Markdown
Collaborator

@Alchez Alchez commented Mar 4, 2026

This came up because FAB needed to handle row-click events, and it was using workarounds using a container div element.


There's two new stories in the ATable section for clickable and open-able table rows.

image image

@Alchez Alchez requested a review from agritheory March 4, 2026 11:20
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@agritheory this is something that Claude generated based on the other icons, but we should have a proper design for it

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2026

Coverage Report for atable

Status Category Percentage Covered / Total
🔵 Lines 80.41% (🎯 70%)
⬆️ +4.11%
813 / 1011
🔵 Statements 79.3% (🎯 70%)
⬆️ +3.86%
866 / 1092
🔵 Functions 81.86% (🎯 70%)
⬆️ +2.62%
176 / 215
🔵 Branches 72.77% (🎯 70%)
⬆️ +2.33%
596 / 819
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
atable/src/components/ARow.vue 75.86%
⬆️ +7.68%
81.08%
⬆️ +19.79%
80%
⬆️ +17.50%
76%
⬆️ +11.00%
105, 111, 116-130, 32
atable/src/components/ARowActions.vue 50.63%
⬆️ +48.10%
26.08%
⬆️ +26.08%
25%
⬆️ +25.00%
53.42%
⬆️ +50.69%
100, 110-112, 125, 128, 135-149, 154-156, 162-166, 171-194, 199, 204-217, 23-29, 45
atable/src/components/ATable.vue 66.15%
⬆️ +2.45%
65.06%
⬆️ +0.43%
84.61%
⬆️ +4.61%
65.35%
⬆️ +2.55%
148-158, 176, 188-189, 253-254, 287, 291, 310-351
atable/src/icons/index.ts 100%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
100%
🟰 ±0%
Unchanged Files
atable/src/utils.ts 100% 100% 100% 100%
atable/src/components/ACell.vue 91.81% 72.85% 100% 94.28% 117, 140-143, 212, 216, 223, 240, 257, 267-269
atable/src/components/AExpansionRow.vue 75% 88.88% 66.66% 75% 43-45
atable/src/components/AGanttCell.vue 57.66% 57.69% 45.45% 60.38% 129, 159-161, 167-169, 176-178, 192-308, 396-397
atable/src/components/AGanttConnection.vue 97.56% 87.5% 100% 100% 89
atable/src/components/ATableColumnFilter.vue 94% 95% 86.95% 93.47% 12-15, 61
atable/src/components/ATableHeader.vue 96% 63.33% 90% 100% 81
atable/src/components/ATableLoading.vue 100% 100% 100% 100%
atable/src/components/ATableLoadingBar.vue 100% 100% 100% 100%
atable/src/components/ATableModal.vue 94.44% 96.15% 100% 100% 22
atable/src/stores/table.ts 88.36% 76.74% 98.46% 89.4% 100, 172, 177, 197-198, 245, 254, 271, 272, 375, 440, 467-469, 505, 570, 594, 602, 624, 631-633, 644, 650-652, 656, 663, 670, 740, 745-749, 837-845, 853-868
Generated in workflow #388 for commit 0063766 by the Vitest Coverage Report Action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2026

Coverage Report for stonecrop

Status Category Percentage Covered / Total
🔵 Lines 87.68% (🎯 70%)
🟰 ±0%
968 / 1104
🔵 Statements 87.37% (🎯 70%)
🟰 ±0%
1017 / 1164
🔵 Functions 88.28% (🎯 70%)
🟰 ±0%
196 / 222
🔵 Branches 78.57% (🎯 70%)
🟰 ±0%
730 / 929
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Unchanged Files
stonecrop/src/composable.ts 86.26% 74.71% 74.35% 87.44% 147, 148, 149, 150, 153-159, 172, 180, 204, 294, 303, 328, 332-334, 424, 433, 440, 456, 476-479, 665-681
stonecrop/src/doctype.ts 100% 100% 100% 100%
stonecrop/src/exceptions.ts 100% 100% 100% 100%
stonecrop/src/field-triggers.ts 84.07% 83.2% 88.23% 84.45% 116-119, 204-213, 233-238, 286-295, 308, 321, 416, 499, 531, 537-541, 551, 612-613, 663-667
stonecrop/src/registry.ts 98.5% 86.2% 100% 98.48% 160
stonecrop/src/schema-validator.ts 100% 88.88% 100% 100%
stonecrop/src/stonecrop.ts 93.75% 73.8% 95.83% 93.58% 45, 164, 280-283
stonecrop/src/composables/operation-log.ts 76.74% 44.44% 73.68% 76.19% 190-191, 196-197, 203-204, 209-210, 215-216
stonecrop/src/plugins/index.ts 85.18% 92.85% 100% 85.18% 80-88
stonecrop/src/stores/hst.ts 88.33% 78.53% 96.66% 87.93% 184, 192, 211, 243-245, 341, 353, 404, 432-450, 518, 533-538, 595-597, 617, 644-648
stonecrop/src/stores/index.ts 100% 100% 100% 100%
stonecrop/src/stores/operation-log.ts 80.99% 71.52% 90.19% 80.82% 23, 132, 194, 230-233, 292, 298-302, 331-335, 343, 372-376, 544-550, 556-562, 574-580, 585, 591, 596-626, 635-636
Generated in workflow #373 for commit 7fb4cb2 by the Vitest Coverage Report Action

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 4, 2026

Coverage Report for aform

Status Category Percentage Covered / Total
🔵 Lines 91.07% (🎯 70%)
🟰 ±0%
245 / 269
🔵 Statements 90.52% (🎯 70%)
🟰 ±0%
258 / 285
🔵 Functions 84.84% (🎯 70%)
🟰 ±0%
56 / 66
🔵 Branches 81.91% (🎯 70%)
🟰 ±0%
154 / 188
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Unchanged Files
aform/src/components/AForm.vue 94.11% 89.09% 93.33% 97.87% 45, 104, 12
aform/src/components/base/CollapseButton.vue 100% 100% 100% 100%
aform/src/components/form/ACheckbox.vue 100% 100% 100% 100%
aform/src/components/form/AComboBox.vue 100% 100% 0% 100%
aform/src/components/form/ADate.vue 66.66% 66.66% 33.33% 66.66% 31, 41, 6
aform/src/components/form/ADatePicker.vue 96.72% 91.66% 88.23% 96.61% 68, 33
aform/src/components/form/ADropdown.vue 96.61% 71.42% 100% 96.36% 121-124
aform/src/components/form/AFieldset.vue 90.9% 87.5% 66.66% 90.9% 8
aform/src/components/form/AFileAttach.vue 0% 0% 0% 0% 26-17
aform/src/components/form/ANumericInput.vue 100% 100% 100% 100%
aform/src/components/form/ATextInput.vue 100% 83.33% 100% 100%
aform/src/components/utilities/Login.vue 87.5% 89.47% 100% 86.95% 76-78
aform/src/directives/mask.ts 95.45% 90.9% 100% 95.34% 69, 91
Generated in workflow #373 for commit 7fb4cb2 by the Vitest Coverage Report Action

@agritheory
Copy link
Copy Markdown
Owner

@crabinak Let's add an "Internal link" and "external link" icon to cover these cases (right-pointing arrow and top-right-point arrow)

@agritheory
Copy link
Copy Markdown
Owner

@Alchez Rename "Open row" to "open record" to disambiguate from "expand row"

@agritheory agritheory marked this pull request as draft March 10, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants