Skip to content

Modify create_hnsw_index#27

Merged
ahill187 merged 5 commits intomasterfrom
hnswlib
Nov 13, 2024
Merged

Modify create_hnsw_index#27
ahill187 merged 5 commits intomasterfrom
hnswlib

Conversation

@ahill187
Copy link
Owner

@ahill187 ahill187 commented Nov 13, 2024

Description

In this PR, I have renamed knn_struct variables to hnsw_index, since there are no structs in Python so this doesn't really make sense. Also, they use the HNSW algorithm, not the KNN algorithm.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (updated docstrings or README files)
  • Tests (added new tests or modified current test suite)
  • Refactoring (changes in the design of the code that don't change the functionality)

Tests

None.

Linked PRs / Issues

ShobiStassen#49

Checklist:

  • I have performed a self-review of my code
  • I have documented my code with appropriate docstrings
  • I have made corresponding changes to the documentation / README files
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ahill187 ahill187 added the refactor Code refactoring label Nov 13, 2024
@ahill187 ahill187 self-assigned this Nov 13, 2024
@ahill187 ahill187 merged commit 9c749dd into master Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant