Fix br tag conversion to newlines in goodreads book descriptions#25
Merged
ahobsonsayers merged 4 commits intoahobsonsayers:mainfrom Jun 14, 2025
Merged
Conversation
- Replace <br /> tags with <br> before html2text processing - html2text library doesn't handle <br /> (with space) format - Add test to verify br tag replacement works correctly Fixes ahobsonsayers#16
ahobsonsayers
approved these changes
Jun 11, 2025
Owner
ahobsonsayers
left a comment
ahobsonsayers
left a comment
There was a problem hiding this comment.
Single minor nit, but this looks incredible! Thanks so much for the contribution!
Owner
|
Looks like I need to fix some tests on my side before this will pass 💀 |
Co-authored-by: Arran Hobson Sayers <32173585+ahobsonsayers@users.noreply.github.com>
Owner
|
Looks like you have a linting failure. We can either nolint the line, or fix it properly. I prefer the latter, but I'm kinda easy either way |
Repository owner
deleted a comment from
arranpx
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tags with
before html2text processing
(with space) format
Fixes #16