-
Notifications
You must be signed in to change notification settings - Fork 12
Add Pushover notification service #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gwhthompson
wants to merge
1
commit into
ahobsonsayers:main
Choose a base branch
from
gwhthompson:feat/pushover
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| package notification | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| "github.com/ahobsonsayers/twigots" | ||
| "github.com/ahobsonsayers/twitchets/config" | ||
| "github.com/gregdel/pushover" | ||
| ) | ||
|
|
||
| type PushoverClient struct { | ||
| app *pushover.Pushover | ||
| recipient *pushover.Recipient | ||
| config config.PushoverConfig | ||
| } | ||
|
|
||
| var _ Client = PushoverClient{} | ||
|
|
||
| func (p PushoverClient) SendTicketNotification(ticket twigots.TicketListing) error { | ||
| notificationMessage, err := RenderMessage(ticket) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| message := pushover.NewMessage(notificationMessage) | ||
| message.Title = ticket.Event.Name | ||
| message.URL = ticket.URL() | ||
| message.URLTitle = "Buy Tickets" | ||
|
|
||
| // Apply optional configuration | ||
| if p.config.Device != nil && *p.config.Device != "" { | ||
| message.DeviceName = *p.config.Device | ||
| } | ||
|
|
||
| if p.config.Sound != nil && *p.config.Sound != "" { | ||
| message.Sound = *p.config.Sound | ||
| } | ||
|
|
||
| if p.config.Priority != nil { | ||
| message.Priority = *p.config.Priority | ||
| } | ||
|
|
||
| _, err = p.app.SendMessage(message, p.recipient) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to send pushover notification: %w", err) | ||
| } | ||
|
|
||
| return nil | ||
| } | ||
|
|
||
| func NewPushoverClient(conf config.PushoverConfig) (PushoverClient, error) { | ||
| app := pushover.New(conf.Token) | ||
| recipient := pushover.NewRecipient(conf.User) | ||
|
|
||
| return PushoverClient{ | ||
| app: app, | ||
| recipient: recipient, | ||
| config: conf, | ||
| }, nil | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| package notification_test | ||
|
|
||
| import ( | ||
| "os" | ||
| "strconv" | ||
| "testing" | ||
|
|
||
| "github.com/ahobsonsayers/twitchets/config" | ||
| "github.com/ahobsonsayers/twitchets/notification" | ||
| "github.com/ahobsonsayers/twitchets/test" | ||
| "github.com/joho/godotenv" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestPushoverSendTicketMessage(t *testing.T) { | ||
| t.Skip("Can only be run manually locally with environment variables set. Comment to run.") | ||
|
|
||
| _ = godotenv.Load(test.ProjectDirectoryJoin(t, ".env")) | ||
|
|
||
| pushoverToken := os.Getenv("PUSHOVER_TOKEN") | ||
| require.NotEmpty(t, pushoverToken, "PUSHOVER_TOKEN is not set") | ||
|
|
||
| pushoverUser := os.Getenv("PUSHOVER_USER") | ||
| require.NotEmpty(t, pushoverUser, "PUSHOVER_USER is not set") | ||
|
|
||
| // Optional: test with device | ||
| pushoverDevice := os.Getenv("PUSHOVER_DEVICE") | ||
| var devicePtr *string | ||
| if pushoverDevice != "" { | ||
| devicePtr = &pushoverDevice | ||
| } | ||
|
|
||
| // Optional: test with sound | ||
| pushoverSound := os.Getenv("PUSHOVER_SOUND") | ||
| var soundPtr *string | ||
| if pushoverSound != "" { | ||
| soundPtr = &pushoverSound | ||
| } | ||
|
|
||
| // Optional: test with priority | ||
| var priorityPtr *int | ||
| if pushoverPriorityStr := os.Getenv("PUSHOVER_PRIORITY"); pushoverPriorityStr != "" { | ||
| priority, err := strconv.Atoi(pushoverPriorityStr) | ||
| require.NoError(t, err, "PUSHOVER_PRIORITY is not an integer") | ||
| priorityPtr = &priority | ||
| } | ||
|
|
||
| client, err := notification.NewPushoverClient(config.PushoverConfig{ | ||
| Token: pushoverToken, | ||
| User: pushoverUser, | ||
| Device: devicePtr, | ||
| Sound: soundPtr, | ||
| Priority: priorityPtr, | ||
| }) | ||
| require.NoError(t, err) | ||
|
|
||
| ticket := testNotificationTicket() | ||
| err = client.SendTicketNotification(ticket) | ||
| require.NoError(t, err) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documented priority range includes "2=emergency" but the validation in config/notification.go only allows -2 to 1. Either update the validation to support priority 2 (which would also require adding retry and expire parameters per Pushover's API), or correct the documentation to match the current implementation by removing "2=emergency" from this comment.