renable github actions for linux (#1135) #19
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This diff reverts D87985301 T246762713 test is failing and blocking releases Depends on D87985301 Reviewed By: mzr Differential Revision: D88140950 fbshipit-source-id: 8488f0f9dca44d9ddc9a9e1a8aa2e9ce10ab0482
Summary: Stop depending on blobimport for test-server-new-repo.t Reviewed By: lmvasquezg Differential Revision: D88145370 fbshipit-source-id: 4deb84900d626667d3eaeabca8b799768b63881a
Summary: When users rapidly select multiple files in the ISL UI, SLOC (Significant Lines of Code) requests were being triggered for each selection change, causing unnecessary server load and potential performance issues. This diff refactors the SLOC fetching mechanism to include debouncing with a 300ms delay. Reviewed By: evangrayk Differential Revision: D88111791 fbshipit-source-id: 07c8f22b34011552814e08e4e10f2490dce102e6
Summary: Migrates test-server-init.t to use testtool_drawdag instead of the deprecated blobimport tool for test repository creation. This change replaces imperative hg commands (hg add, hg ci, hg mv) with declarative testtool_drawdag syntax, making the test more maintainable and aligned with the blobimport deprecation effort. The test validates the same original functionality: basic Mononoke server initialization, repository cloning, pull operations by hash, merge DAG structure, rename tracking, and file history through merges. Reviewed By: clara-9 Differential Revision: D88011598 fbshipit-source-id: 18ec559b6158f8ea2284f0d3c844159a41027c68
Summary: In this diff I add the ability to ratelimit Atlas. For now we just check for `clientinfo_atlas` being set to True. Later we will be able to include addtional metadata to check for in the struct, and we'll be able to extend the Thrift struct to match those Note that for QPS ratelimiting we will be setting a single limit but it will apply to each main_client_id individually: https://www.internalfb.com/code/fbsource/[7c2c14a89c569823b177ca7696b443340c7d022f]/fbcode/eden/mononoke/edenapi_service/src/middleware/rate_limiter.rs?lines=88 I've already set up atlas to get a different main_clientId in each environment: D87645412 Reviewed By: gustavoavena Differential Revision: D87862487 fbshipit-source-id: c651f68acc0964d7c557e5ae055ab1640e50dd28
Summary: Add comprehensive high-level documentation of Mononoke. Reviewed By: clara-9 Differential Revision: D88053662 fbshipit-source-id: 741b20cab138bb7ec79da8b18b92625dc3dfa455
Summary: I also had to add a fixup to prevent a necessary macos dependency from being removed from version 5. Reviewed By: dtolnay Differential Revision: D88180564 fbshipit-source-id: 5a02dc73800e9b924ad59517d7d5c40c2bf27d34
Summary: Create nupkg builder target for eden Based on targets from https://www.internalfb.com/code/fbsource/[f06789d9dc587a3ba0d4b49a4826ce5ba9d12c9e]/fbcode/eden/fs/facebook/packaging/make-win-nupkg.py?lines=51-59 next steps: add a choco install file to install into tools/fb-eden-test-windows Reviewed By: genevievehelsel Differential Revision: D88110539 fbshipit-source-id: d7a4d00d873adbc16e384fa0427734a7bcf53469
Summary: Add new file build_targets.bzl that contains all the targets used to build rpm/fbpkg/nupkg targets. This diff contains the function that generates the required features for rpmbuilder. Followup diffs will be for fbpkg and nupkg Reviewed By: genevievehelsel Differential Revision: D88095312 fbshipit-source-id: f5f7edf917dd26766ac7cfbd04c0bcf4772e10e6
Summary: This change ensures that users are prompted to confirm any suggested edits before continuing with merge conflict resolution. This prevents unintentional acceptance or rejection of AI-suggested edits during the merge process. This improves the user experience by giving explicit control over suggested edits during merge workflows. Reviewed By: evangrayk Differential Revision: D88113593 fbshipit-source-id: f5d7b1b7572762f0d284ff7fdc0b3da41c2e0268
Summary: GitHub commits: facebook/buck2-prelude@41e46ba facebook/facebook-for-woocommerce@45e7253 facebook/fb303@7e0a5c5 facebook/fbthrift@8022868 facebook/folly@f0a26b3 facebook/mvfst@b4c2756 facebook/proxygen@a4001b2 facebook/wangle@c9482f3 facebookexperimental/edencommon@37e11f0 facebookexperimental/rust-shed@ec159cb facebookincubator/fizz@c1545f8 https://github.com/facebookincubator/llm_orchestrator/commit/27395854918575be51bd6d71532b2d26cffbafe8 Reviewed By: bigfootjon fbshipit-source-id: a589ca8584a3cb63e4675fcf04ec2136aa00ec6e
Summary: The recommended bookmarks GK has been on 100% for good chunks of time (although disabled at the moment) and the feature is stable. With the next diff, users who do not have a recommended bookmark will simply not see the recommended bookmarks section in the bookmarks manager. Essentially, having a recommended bookmark or not will be the new determiner if things are shown. Removing the GK allows for lower latency on loading the commit tree on startup. Reviewed By: evangrayk Differential Revision: D86217927 fbshipit-source-id: 6d28b1d1b3d201753825e55b3cd37c5c1b3da659
Summary: This will be used for cross-repo log use case. For cross-repo case, single rev number is not enough to uniquely represent a node cross repos. This diff extend dagwalker() to support custom id generators, so we can add repo information to the node ids. Reviewed By: muirdm Differential Revision: D87939034 fbshipit-source-id: 16ac5f17424c4caa8e7f73dab269a4bcf15cefe8
Summary: We will be using (u8, i64) to represent (repo_id, rev_number) for cross-repo case. Reviewed By: muirdm Differential Revision: D87940286 fbshipit-source-id: ffd75d025af3f0b7b7fbc08a30f185b12d7f4b01
Summary: Currently, we don't special handling for XREPOPARENT in renderdag Reviewed By: muirdm Differential Revision: D87940602 fbshipit-source-id: dc0cb55357509b2b531344fba17996d2560031df
Summary: `basectx` has the "repo()" function. And this will unblock the changes in D87943583, where we get the repo object from ctx for cross-repo log history. Reviewed By: muirdm Differential Revision: D87957458 fbshipit-source-id: f3f54506035aa41bcfeb0f5a497260723c84c086
Summary: For cross-repo log case, ctx.repo() can be different from the original repo. This diff makes it use ctx.repo() inside the loop. Reviewed By: muirdm Differential Revision: D87943583 fbshipit-source-id: 699e7713440c46e12c4961c926c9e828f1fae263
Summary: In cross-repo case, the graph node id will be a (repo_id, rev_number) tuple Reviewed By: muirdm Differential Revision: D87943585 fbshipit-source-id: 95b59df19d06119b475df8584b4e226cc8245f66
Summary: The `displayer.show()` uses `ctx.rev()` as the key for `self.hunk`, so `displayer.hunk.pop()` should also use `ctx.rev()` as the key. It works previously because graph_node_id equals ctx.rev() for now. But it will be changed when we introduce cross-repo node ids. Reviewed By: muirdm Differential Revision: D87943588 fbshipit-source-id: eb2c16a79b9fec3bea854abd06e27d526c61f713
Summary: We will be using mark_first() and mark_last() to check if an item from an iterable is the first or last. Reviewed By: muirdm Differential Revision: D87944350 fbshipit-source-id: aca2553fe5cc12dd235f070f4fdadddd6d194ff6
Summary: This refactors displaygraph() to accept dict-based parameters (repogetrenamed, repofilematcher) instead of single values. This prepares the function for cross-repo log support where we need to track different values for different repositories. The dictionary keys are repo.root paths, allowing us to look up the appropriate values for each repository. Reviewed By: muirdm Differential Revision: D87945878 fbshipit-source-id: a90a246ceb3efea2282105dd4bcacc984ad44e9d
Summary: Extracts the dag walker creation logic from graphlog() into a separate _logdagwalker() helper function. This prepares for adding cross-repo log support without making graphlog() too complex. The helper function populates repogetrenamed and repofilematcher dicts and returns the revdag. Reviewed By: muirdm Differential Revision: D87946671 fbshipit-source-id: a40c5f24fc163a0c8be4b205d3d6025eecdeb553
Summary: Move & rename _getxrepoinfo() function for better reuse. Reviewed By: muirdm Differential Revision: D87957455 fbshipit-source-id: ccef9b48a96095ca65adb47d17dc8dec7f41fcde
Summary: graphlog() function's parameters are identical to log command ones, so the type of `pats` should be a tuple of strs. This diff add type annotations to graphlog() and also fix the wrong callsites. Differential Revision: D87981500 fbshipit-source-id: b6fdd39ae2e37b893824f83efc2e0d7d47e98504
Summary: Implements the core cross-repo log functionality in _logdagwalker(). This enables "sl log --graph" to follow history across repository boundaries for subtree imports. Reviewed By: muirdm Differential Revision: D87957456 fbshipit-source-id: f4cc77342378c47951455549e6881b96c34453dc
Summary: Adds custom node id func to _logdagwalker() function and return node ids as (repoid, rev) tuples instead of rev numbers. This enables unique identification of nodes across multiple repositories for cross-repo log. Reviewed By: muirdm Differential Revision: D87957457 fbshipit-source-id: 0c78b5f44d361d16c275f955b02eb1545d285742
Summary: Setting xreponame for cross-repo log history will enable different color and format for external commits. Reviewed By: muirdm Differential Revision: D87957459 fbshipit-source-id: 7059e8afd8cd68fdf814547562975fe2c50fe176
Summary: Add a config flag to disable cross-repo follow logic, in case we need to switch it off unexpectedly. Reviewed By: muirdm Differential Revision: D87959738 fbshipit-source-id: 96701366eba9d90a373438f7bea667e983266d09
Summary: The nodes() function is only referenced by graphrevs(), but graphrevs() is not used anywhere in the codebase. This diff removes both functions. Reviewed By: muirdm Differential Revision: D88073683 fbshipit-source-id: a1282a8f860ffde0079a99bff771f2b0c31e3fbb
Differential Revision: D88157563 fbshipit-source-id: 4080489e7154a242c78c1e356f775d302b2245f9
Summary: This enum is left over from when the land service was in development, and doesn't belong on the SCS interface. The methods that used it were removed in D41470321. Remove the enum. Reviewed By: chiara125 Differential Revision: D88071747 fbshipit-source-id: 727f186af70913fa355312862d06c40c223b35c0
Summary: Fixed the populate-wal command to use the correct multiplex_id when inserting WAL entries, allowing the blobstore healer to find and process them correctly. The healer queries WAL entries by multiplex_id from the MultiplexedWal configuration. The populate-wal command was incorrectly using target_blobstore_id (individual blobstore ID like 0) instead of the actual multiplex_id (configuration-level ID like 1), causing a mismatch. Migrate the blobstore healer integration test from the deprecated `blobimport` tool to the modern `testtool drawdag` approach. This removes the dependency on blobimport and uses the new `populate-wal` command to simulate blobstore write failures for healer testing. Reviewed By: clara-9 Differential Revision: D87931473 fbshipit-source-id: c63484072ebd90925f02fa296b0d085e86d4b50e
ahornby
force-pushed
the
export-D82818583
branch
from
e2ae0b5 to
59f18bd
Compare
Summary: Pull Request resolved: facebook#1157 enable CI now that the build and tests are fixed. Enabling for linux only to limit noise for the teams Reviewed By: zzl0 Differential Revision: D88010549 fbshipit-source-id: 4d5640211a18238156205900d9af976790f84899
Summary: GitHub commits: facebook/buck2-prelude@c754f2f facebook/facebook-for-woocommerce@100e195 facebook/fb303@1aca35e facebook/fbthrift@674867a facebook/folly@6a4ddcd facebook/mvfst@a5683c7 facebook/proxygen@9b1d618 facebook/wangle@45ff542 facebookexperimental/edencommon@3fd57ca facebookexperimental/rust-shed@cac1924 facebookincubator/fizz@01b31be https://github.com/facebookincubator/llm_orchestrator/commit/44f51f4d0e5e632ddb96436504bbdb5569ae6a62 Reviewed By: bigfootjon fbshipit-source-id: 7ed28634a21cc800ccd630a3b53feea8d77f537b
The internal and external repositories are out of sync. This Pull Request attempts to brings them back in sync by patching the GitHub repository. Please carefully review this patch. You must disable ShipIt for your project in order to merge this pull request. DO NOT IMPORT this pull request. Instead, merge it directly on GitHub using the MERGE BUTTON. Re-enable ShipIt after merging.
Summary: GitHub commits: facebook/buck2-prelude@875adfe facebook/facebook-for-woocommerce@f2d3323 facebook/fb303@33ece9d facebook/fbthrift@c512755 facebook/folly@0d3d5e7 facebook/mvfst@d4ddf81 facebook/proxygen@df7e656 facebook/wangle@2e5954b facebookexperimental/edencommon@657ddb4 facebookexperimental/rust-shed@33006dc facebookincubator/fizz@134192e https://github.com/facebookincubator/llm_orchestrator/commit/696a907443d8d7abe3b5eeddf6471e996100706d Reviewed By: bigfootjon fbshipit-source-id: de7563e567583a10418359674de137bc052fe895
ahornby
force-pushed
the
export-D82818583
branch
from
59f18bd to
472d537
Compare
Summary: During this week I'm testing remote diffs in SCS, enabling it for the fbcode and www, in steps. I have to include the specific repo in the experiment to be able to see the impact with and without remote diffs. Reviewed By: chiara125 Differential Revision: D88274758 fbshipit-source-id: f169ed4ba4f847f16d2de521fd0eaa90c5253b67
Summary: Renable mononoke linux github actions so that folks externally can see that it current builds, and so they can see the breaks easily if it later doesn't build. Added support for pinning rust version as during developement needed to pin to rust 1.90 as didn't yet compile with 1.91. In the meantime 1.91 support landed so pinned to 1.91. Also saw that it was running out of disk space on the github actions runner so switched it to use MinSizeRel cmake build type and added a cargo mapping for it Reviewed By: genevievehelsel Differential Revision: D82818583
ahornby
force-pushed
the
export-D82818583
branch
from
472d537 to
cb5f042
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Renable mononoke linux github actions
Differential Revision: D82818583