Skip to content

feat: decoded media via NIXL #3988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: decoded media via NIXL #3988

wants to merge 8 commits into from

Conversation

@milesial
Copy link
Contributor

@milesial milesial commented Oct 30, 2025 •
edited
Loading

Overview:

See #3630 for context, this MR is a subset of it, focusing on NIXL metadata passing, building on top of #3971.

image 507323054-8f7b5508-af4e-48c0-899e-609ef80b879c

Summary by CodeRabbit

  • New Features

    • Integrated RDMA support for improved media data handling and memory management.
    • Added NIXL metadata integration for enhanced multimedia content processing.

  • Improvements

    • Enhanced serialization support for image data with additional format options.
    • Refined media processing pipeline for better performance and reliability.

@milesial milesial requested a review from a team as a code owner October 30, 2025 16:23
@github-actions github-actions bot added the feat label Oct 30, 2025
@milesial milesial force-pushed the alexandrem/frontend-image-decoding branch from cbe3353 to 5be5da0 Compare October 30, 2025 19:10
@milesial milesial mentioned this pull request Oct 31, 2025
Merged
@milesial milesial force-pushed the alexandrem/frontend-image-decoding branch 6 times, most recently from 6895b84 to eb75d6f Compare November 3, 2025 19:44
@rmccorm4
Copy link
Contributor

rmccorm4 commented Nov 4, 2025

@milesial please fix the merge conflicts

@milesial milesial force-pushed the alexandrem/frontend-image-decoding-nixl branch from 6a0920b to f19f157 Compare November 4, 2025 00:36
@milesial
Copy link
Contributor Author

milesial commented Nov 4, 2025

@milesial please fix the merge conflicts

Yes just rebased, diff looks nicer now

rmccorm4
rmccorm4 reviewed Nov 4, 2025
View reviewed changes
@milesial milesial force-pushed the alexandrem/frontend-image-decoding branch from 4dbec11 to b888111 Compare November 4, 2025 04:36
@milesial milesial requested a review from a team as a code owner November 4, 2025 04:36
@milesial milesial force-pushed the alexandrem/frontend-image-decoding-nixl branch from f19f157 to ef274b4 Compare November 4, 2025 08:37
@milesial milesial force-pushed the alexandrem/frontend-image-decoding branch from b888111 to bed5bd0 Compare November 4, 2025 18:03
@milesial milesial force-pushed the alexandrem/frontend-image-decoding-nixl branch from ef274b4 to f09816e Compare November 4, 2025 18:04
@milesial milesial force-pushed the alexandrem/frontend-image-decoding-nixl branch from 22891ca to b0221bb Compare November 10, 2025 22:23
@milesial milesial force-pushed the alexandrem/frontend-image-decoding-nixl branch from 92c6acf to a2687d2 Compare November 10, 2025 22:37
@milesial milesial force-pushed the alexandrem/frontend-image-decoding-nixl branch from a2687d2 to 1c753ec Compare November 11, 2025 01:21
@milesial
feat: decoded media via NIXL
cfee423 
Signed-off-by: Alexandre Milesi <milesial@users.noreply.github.com>
@milesial
feat: NIXL stub support
43a3f0c 
Signed-off-by: Alexandre Milesi <milesial@users.noreply.github.com>
@milesial
chore: cleanups
01f94d6 
Signed-off-by: Alexandre Milesi <milesial@users.noreply.github.com>
@milesial
fix: image-rs serde
0aabc41 
Signed-off-by: Alexandre Milesi <milesial@users.noreply.github.com>
@milesial
feat: switch to media-nixl feature flag
d33d718 
Signed-off-by: Alexandre Milesi <milesial@users.noreply.github.com>
@milesial
chore: cleanups
94d027d 
Signed-off-by: Alexandre Milesi <milesial@users.noreply.github.com>
@milesial milesial force-pushed the alexandrem/frontend-image-decoding-nixl branch from 1c753ec to 94d027d Compare November 11, 2025 17:13
@KrishnanPrash KrishnanPrash mentioned this pull request Nov 13, 2025
Open
@ayushag-nv
Merge branch 'main' into alexandrem/frontend-image-decoding-nixl
90fcf54 
Signed-off-by: Ayush Agarwal <ayushag@nvidia.com>
@rmccorm4
Copy link
Contributor

rmccorm4 commented Nov 17, 2025

@ayushag-nv can you fix the failing rust checks?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grahamking grahamking grahamking left review comments

@rmccorm4 rmccorm4 rmccorm4 left review comments

@jthomson04 jthomson04 jthomson04 left review comments

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@nv-anants nv-anants nv-anants left review comments

@ayushag-nv ayushag-nv ayushag-nv approved these changes

@krishung5 krishung5 Awaiting requested review from krishung5

Assignees

No one assigned

Labels

feat frontend `python -m dynamo.frontend` and `dynamo-run in=http|text|grpc` multimodal size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@milesial @rmccorm4 @grahamking @jthomson04 @nv-anants @ayushag-nv