E3SMv3 AMIP preprocess as ERA5 naming standard #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Arcomano1234
left a comment
Arcomano1234
left a comment
There was a problem hiding this comment.
Thank you for processing this data! I left one comment and I had another comment regarding the naming of the configuration yaml. It seems that this is replacing an existing config from some ramped run that starts in 1920. If this is the case I suggest we re-name the old config from e3sm-1deg-8layer-v3.yaml to something like e3sm-1deg-8layer-v3-ramped.yaml and make a new config for this PR to something like e3sm-1deg-8layer-v3-AMIP.yaml to make the data processing history more documented.
| datasets[varname] = ds | ||
| del var_paths["time_invariant"] | ||
| for varname, paths in var_paths.items(): | ||
| print(varname) |
Contributor
There was a problem hiding this comment.
Is this print statement intentional? Probably don't need it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates E3SMv3 AMIP preprocessing to follow ERA5 standard, which includes variable renaming, adding CO2 concentration, and updating topography.