Draft
Conversation
Communicator keeps a Quantity-based API QuantityHaloSpec gets it's own file (re-use)
Communicator retains a Quantity API
Add helper function on DycoreState
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Our Halo Exchange use a pattern of memory specification at init and then at runtime passing the actual memory to be exchanged. The type of the parameters is Quantity, but truly it doesn't need such a high level concept and simple arrays would do. Moving to simple arrays would allow for DaCe orchestration to use the same code pattern.
Code changes:
Checklist
Before submitting this PR, please make sure:
pace-util, HISTORY has been updated