Refactor makefile and introduce multiarch build system #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
We'll replace cborg-coder for goose, as a totally open alternative. See
https://github.com/dragon-ai-agent/run-goose-obo/blob/main/action.yml
…On Tue, Jun 3, 2025 at 8:10 AM Nico Matentzoglu ***@***.***> wrote:
Fixes #17 <#17>
Still testing this but you get the picture. I added a help command.
I cant test it because I don't have access to CBORG; and none of the
subsequent commands (aurelian etc) work for me; Lets iterate and you let me
know how it goes for you.
------------------------------
You can view, comment on, or merge this pull request online at:
#18
Commit Summary
- 840eb9e
<840eb9e>
Refactor makefile and introduce multiarch build system
- dc0cb65
<dc0cb65>
Adding GH_TOKEN logic back
- fa11ff1
<fa11ff1>
Fix bug in build command
File Changes
(2 files <https://github.com/cmungall/odk-ai/pull/18/files>)
- *M* Dockerfile
<https://github.com/cmungall/odk-ai/pull/18/files#diff-dd2c0eb6ea5cfc6c4bd4eac30934e2d5746747af48fef6da689e85b752f39557>
(2)
- *M* Makefile
<https://github.com/cmungall/odk-ai/pull/18/files#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52>
(107)
Patch Links:
- https://github.com/cmungall/odk-ai/pull/18.patch
- https://github.com/cmungall/odk-ai/pull/18.diff
—
Reply to this email directly, view it on GitHub
<#18>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAMMOM6FVVYU2EA4AVORWT3BW3FHAVCNFSM6AAAAAB6QCJ7UCVHI2DSMVQWIX3LMV43ASLTON2WKOZTGEYTIMZZGMYDONI>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
matentzn
commented
Jun 3, 2025
| @@ -1,4 +1,4 @@ | |||
| FROM obolibrary/odkfull:latest | |||
| FROM obolibrary/odkfull:v1.6 | |||
Author
There was a problem hiding this comment.
Better fix the ODK base version to avoid spurious failures?
|
|
||
| .PHONY: help | ||
|
|
||
| help: |
Author
There was a problem hiding this comment.
Added help as I usally do now for all makefiles
|
|
||
| ifeq ($(RESET_MULTIARCH_ON_BUILD),true) | ||
|
|
||
| reset-multiarch: |
Author
There was a problem hiding this comment.
This is needed sometimes, for no conceivable reason.
Author
|
@cmungall cool, you can use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17
Still testing this but you get the picture. I added a help command.
I cant test it because I don't have access to CBORG; and none of the subsequent commands (aurelian etc) work for me; Lets iterate and you let me know how it goes for you.