This repository was archived by the owner on Dec 7, 2017. It is now read-only.
Updated static library settings #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added note to Vim command key that the Escape key is supported.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into some issues when building the project as a static lib. The changes made include some cleanup, some best practice build settings for external static libs as well as suggestions made by Apple for static libs (https://developer.apple.com/library/ios/technotes/iOSStaticLibraries/Articles/configuration.html).
The library, when linked statically, should be included with `#import "MagicKit-iOS/MagicKit.h" (as suggested by Apple).
This builds successfully with Xcode 6.1. I changed the target to iOS 7.0, but this is probably completely unnecessary. Also, the Cocoa libs are not loaded. I haven't build anything for Mac OS X, so I'm not sure how to guard against loading it when building iOS projects. If you want to use it for Mac OS X, all you should need to do is uncomment <Cocoa/Cocoa.h> in the pch file.
My app, Buffer Editor, now uses this lib in production. Thank you for all your hard work!