Skip to content

fix(open-file): strip Next.js App Router virtual path segments before editor launch #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Logesh-waran2003 wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −4
Open

fix(open-file): strip Next.js App Router virtual path segments before editor launch #219

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9bbc2a
fix(open-file): strip Next.js App Router virtual path segments before…
Logesh-waran2003 Mar 6, 2026
4455b41
fix(open-file): normalize path in fallback URL path too
Logesh-waran2003 Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions packages/react-grab/src/utils/open-file.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,19 @@
import { checkIsNextProject } from "../core/context.js";
import { buildOpenFileUrl } from "./build-open-file-url.js";

// Next.js App Router dev server injects a virtual path segment into stack frames.
// Strip it before passing the path to the launch-editor endpoint.
const stripAppRouterVirtualSegments = (filePath: string): string =>
filePath.replace(/\/\(app-pages-browser\)\//g, "/");

const tryDevServerOpen = async (
filePath: string,
lineNumber: number | undefined,
): Promise<boolean> => {
const isNextProject = checkIsNextProject();
const params = new URLSearchParams({ file: filePath });
const params = new URLSearchParams({
file: isNextProject ? stripAppRouterVirtualSegments(filePath) : filePath,
});
Copy link

@cursor cursor bot Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Path stripped twice due to redundant normalization

Low Severity

stripAppRouterVirtualSegments is applied twice for Next.js projects — once in openFile before passing normalizedPath to tryDevServerOpen, and again inside tryDevServerOpen on the already-stripped path. Since tryDevServerOpen is private and only called from openFile, one of these two call sites is redundant. The cleanest fix is to remove the conditional strip inside tryDevServerOpen (line 15), since the caller already normalizes the path.

Additional Locations (1)

Fix in Cursor Fix in Web


const lineKey = isNextProject ? "line1" : "line";
const columnKey = isNextProject ? "column1" : "column";
Expand All @@ -25,15 +32,19 @@ export const openFile = async (
lineNumber: number | undefined,
transformUrl?: (url: string, filePath: string, lineNumber?: number) => string,
): Promise<void> => {
const normalizedPath = checkIsNextProject()
? stripAppRouterVirtualSegments(filePath)
: filePath;

const wasOpenedByDevServer = await tryDevServerOpen(
filePath,
normalizedPath,
lineNumber,
).catch(() => false);
if (wasOpenedByDevServer) return;

const rawUrl = buildOpenFileUrl(filePath, lineNumber);
const rawUrl = buildOpenFileUrl(normalizedPath, lineNumber);
const url = transformUrl
? transformUrl(rawUrl, filePath, lineNumber)
? transformUrl(rawUrl, normalizedPath, lineNumber)
: rawUrl;
window.open(url, "_blank", "noopener,noreferrer");
};