Draft
Conversation
…e-at-position Both files were defined but never imported or called anywhere in the codebase. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@react-grab/cli
grab
@react-grab/amp
@react-grab/claude-code
@react-grab/codex
@react-grab/copilot
@react-grab/cursor
@react-grab/droid
@react-grab/gemini
@react-grab/opencode
react-grab
@react-grab/relay
@react-grab/utils
commit: |
Three timer ID checks used truthy checks (if (timerId)) instead of the consistent explicit null check (if (timerId !== null)) used throughout the rest of the file. While window.setTimeout() never returns 0 in practice, this inconsistency violated the established pattern and was a latent correctness risk. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The copilot handler was mapping browserSessionId → browserSessionId in copilotSessionMap on close, then passing this back as the --resume arg on the next run. This would send the browser's internal session ID to the copilot CLI instead of the actual copilot session ID. The fix mirrors the cursor/claude-code pattern: only set the session map if a capturedCopilotSessionId was actually obtained from the CLI output. Since the copilot CLI outputs plain text (not JSON with a session_id), this variable remains undefined and the map is never incorrectly populated. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes from Slack bot
Summary by cubic
Removed two unused text utilities from
packages/react-grab:create-text-node-boundsandget-text-node-at-position. Also fixed timer cleanup null checks there and madepackages/provider-copilotstore the real Copilot session ID for resume.Written for commit e0d75b3. Summary will update on new commits.